From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756264AbdERNQN (ORCPT ); Thu, 18 May 2017 09:16:13 -0400 Received: from mx2.suse.de ([195.135.220.15]:38686 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755840AbdERNQK (ORCPT ); Thu, 18 May 2017 09:16:10 -0400 Date: Thu, 18 May 2017 15:16:08 +0200 From: Libor Pechacek To: Miroslav Benes Cc: jpoimboe@redhat.com, jeyu@redhat.com, jikos@kernel.org, pmladek@suse.com, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] livepatch: force transition process to finish Message-ID: <20170518131608.GG9599@fm.suse> References: <20170518120043.7205-1-mbenes@suse.cz> <20170518120043.7205-4-mbenes@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170518120043.7205-4-mbenes@suse.cz> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 18-05-17 14:00:43, Miroslav Benes wrote: [...] > Admin can do that now by writing 2 to force sysfs attribute in livepatch > sysfs directory. TIF_PATCH_PENDING is then cleared for all tasks and the > transition can finish successfully. [...] > --- a/include/linux/livepatch.h > +++ b/include/linux/livepatch.h > @@ -31,6 +31,7 @@ > > /* values for sysfs force attribute */ > #define KLP_FORCE_FAKE 1 > +#define KLP_FORCE_UNMARK 2 Again, needs documentation. I would consider using symbolic names instead of numbers, like /sys/power/state does, even more friendly. Possibility to read a list of available actions would help user space tools identify what is available in case the list grows in the future. Libor -- Libor Pechacek SUSE Labs