From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755037AbdERN4h (ORCPT ); Thu, 18 May 2017 09:56:37 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:42223 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751486AbdERN4f (ORCPT ); Thu, 18 May 2017 09:56:35 -0400 X-ME-Sender: X-Sasl-enc: Gm8wifZ8JjKupC5vdcVplE9VtP8gdHDZuVjT4rNHFN+e 1495115794 Date: Thu, 18 May 2017 15:56:26 +0200 From: Greg KH To: Matej Dujava Cc: Sudip Mukherjee , Teddy Wang , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/7] staging: sm750fb: unifying macro usage and definitions Message-ID: <20170518135626.GC6772@kroah.com> References: <1494885252-22831-1-git-send-email-mdujava@kocurkovo.cz> <1494926423-6476-3-git-send-email-mdujava@kocurkovo.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494926423-6476-3-git-send-email-mdujava@kocurkovo.cz> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 16, 2017 at 11:20:18AM +0200, Matej Dujava wrote: > This patch adds tabs into macro definitions so all rhs are on same column. > Move MHz macro from ddk_chip.c to ddk_chip.h. > > Signed-off-by: Matej Dujava > --- > drivers/staging/sm750fb/ddk750_chip.c | 18 ++++---- > drivers/staging/sm750fb/ddk750_chip.h | 5 +- > drivers/staging/sm750fb/ddk750_display.h | 78 ++++++++++++++++---------------- > drivers/staging/sm750fb/ddk750_hwi2c.c | 4 +- > drivers/staging/sm750fb/sm750.h | 6 +-- > 5 files changed, 55 insertions(+), 56 deletions(-) > > diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c > index 944dd25..64d0a53 100644 > --- a/drivers/staging/sm750fb/ddk750_chip.c > +++ b/drivers/staging/sm750fb/ddk750_chip.c > @@ -5,8 +5,6 @@ > #include "ddk750_chip.h" > #include "ddk750_power.h" > > -#define MHz(x) ((x) * 1000000) > - > static logical_chip_type_t chip; > > logical_chip_type_t sm750_get_chip_type(void) > @@ -36,7 +34,7 @@ static unsigned int get_mxclk_freq(void) > unsigned int M, N, OD, POD; > > if (sm750_get_chip_type() == SM750LE) > - return MHz(130); > + return MHZ(130); But MHz makes more sense, don't you think so? Please leave that as-is. thanks, greg k-h