From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754885AbdERTqt (ORCPT ); Thu, 18 May 2017 15:46:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:39758 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221AbdERTqq (ORCPT ); Thu, 18 May 2017 15:46:46 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D962223986 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Thu, 18 May 2017 15:46:43 -0400 From: Steven Rostedt To: Doug Anderson Cc: Matthias Kaehlcke , Ingo Molnar , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ring-buffer: Remove unused function __rb_data_page_index() Message-ID: <20170518154643.4306b37d@gandalf.local.home> In-Reply-To: References: <20170518001415.5223-1-mka@chromium.org> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 May 2017 12:40:02 -0700 Doug Anderson wrote: > Hi, > > This appears to have been introduced in 2009 by commit afbab76a62b6 > ("ring-buffer: have read page swap increment counter with page > entries"), which removed the user of the function but not the function > itself. If folks were so inclined, this could be picked back to > linux-stable, but I'm not sure it's worth it. It doesn't do anything but waste some disk space in the source repository. It's a static inline function, which means it's not created unless something calls it. Thus, not worth the stable churn. -- Steve