From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932287AbdERU7m (ORCPT ); Thu, 18 May 2017 16:59:42 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:33868 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754697AbdERU7l (ORCPT ); Thu, 18 May 2017 16:59:41 -0400 X-Auth-Info: bSyW4yjGs7eGjB4vme7eiSXYEn9JkMZK5OUrwkAOq4o= Date: Thu, 18 May 2017 22:59:35 +0200 From: Anatolij Gustschin To: stillcompiling@gmail.com, joshua.clayton@uniwest.com, bst@pengutronix.de Cc: linux-fpga@vger.kernel.org, atull@kernel.org, moritz.fischer@ettus.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com Subject: Re: [PATCH v10 2/3] fpga manager: Add altera-ps-spi driver for Altera FPGAs Message-ID: <20170518225935.7948d7a5@crub> In-Reply-To: <1495045422-19183-2-git-send-email-agust@denx.de> References: <1495045422-19183-1-git-send-email-agust@denx.de> <1495045422-19183-2-git-send-email-agust@denx.de> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 May 2017 20:23:41 +0200 Anatolij Gustschin agust@denx.de wrote: ... >+ if (!IS_ERR(conf->confd)) { >+ if (!gpiod_get_raw_value_cansleep(conf->confd)) { >+ dev_err(&mgr->dev, "CONF_DONE is low!\n"); as we agreed in the another thread, gpiod_get_value_cansleep() should be used here. Another change: s/low/inactive/ -- Anatolij