From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754732AbdESANe (ORCPT ); Thu, 18 May 2017 20:13:34 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:42640 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754330AbdESANb (ORCPT ); Thu, 18 May 2017 20:13:31 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BAB1760DB6 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Thu, 18 May 2017 17:13:28 -0700 From: Stephen Boyd To: Eric Anholt Cc: dri-devel@lists.freedesktop.org, Russell King , linus.walleij@linaro.org, Michael Turquette , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] drm/pl111: Register the clock divider and use it. Message-ID: <20170519001328.GA20170@codeaurora.org> References: <20170508193348.30236-1-eric@anholt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170508193348.30236-1-eric@anholt.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/08, Eric Anholt wrote: > This is required for the panel to work on bcm911360, where CLCDCLK is > the fixed 200Mhz AXI41 clock. The rate set is still passed up to the > CLCDCLK, for platforms that have a settable rate on that one. > > v2: Set SET_RATE_PARENT (caught by Linus Walleij), depend on > COMMON_CLK. > > Signed-off-by: Eric Anholt Reviewed-by: Stephen Boyd One minor comment below > diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c > index 39a5c33bce7d..2d924a6bf43c 100644 > --- a/drivers/gpu/drm/pl111/pl111_display.c > +++ b/drivers/gpu/drm/pl111/pl111_display.c > @@ -288,6 +296,126 @@ const struct drm_simple_display_pipe_funcs pl111_display_funcs = { [...] > + > + return 0; > +} > + > +const struct clk_ops pl111_clk_div_ops = { static? > + .recalc_rate = pl111_clk_div_recalc_rate, > + .round_rate = pl111_clk_div_round_rate, > + .set_rate = pl111_clk_div_set_rate, > +}; > + > +static int -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project