From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755428AbdESA52 (ORCPT ); Thu, 18 May 2017 20:57:28 -0400 Received: from mail-by2nam03on0040.outbound.protection.outlook.com ([104.47.42.40]:53216 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752261AbdESA5X (ORCPT ); Thu, 18 May 2017 20:57:23 -0400 Authentication-Results: spf=softfail (sender IP is 192.88.168.50) smtp.mailfrom=gmail.com; thalmeier.at; dkim=none (message not signed) header.d=none;thalmeier.at; dmarc=fail action=none header.from=gmail.com; Date: Fri, 19 May 2017 08:57:18 +0800 From: Peter Chen To: Michael Thalmeier CC: Peter Chen , Greg Kroah-Hartman , , , Subject: Re: [PATCH] usb: chipidea: debug: check before accessing ci_role Message-ID: <20170519005718.GA7460@b29397-desktop> References: <20170518141414.30798-1-michael.thalmeier@hale.at> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170518141414.30798-1-michael.thalmeier@hale.at> User-Agent: Mutt/1.5.24 (2015-08-30) X-EOPAttributedMessage: 0 X-Matching-Connectors: 131396290405434750;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.168.50;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(39380400002)(39850400002)(39400400002)(39410400002)(39860400002)(39450400003)(39840400002)(2980300002)(24454002)(189002)(199003)(9170700003)(86362001)(77096006)(4326008)(5660300001)(50986999)(87572001)(76176999)(54356999)(106466001)(6246003)(33716001)(82202002)(73392002)(73972006)(81442002)(38730400002)(110136004)(105596002)(6260500002)(2950100002)(6916009)(189998001)(97756001)(229853002)(8656002)(50466002)(76482006)(8936002)(305945005)(498600001)(81166006)(46406003)(8676002)(4001350100001)(9686003)(83506001)(104016004)(55016002)(83322999)(54906002)(1076002)(47776003)(97736004)(2906002)(33656002)(23726003)(356003)(53936002)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB166;H:tx30smr01.am.freescale.net;FPR:;SPF:SoftFail;MLV:ovrnspm;MX:1;A:1;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD032;1:mNdJ+e3SV6SDKb+qP4vRqLCqeXh4AZg65Y7jkmtMx+JBLaB7apNOdX7VQLlaYcUnXSsUxmlFeBZ93XUB5XeMMd/SVlIjNFZ7Q5QGTNbc+4ZYDPccBnmddWnaQlYrJFbMN8dUo6w4vOU/vkL8nWvgTPHj8hHJ6SbNWwkVf33kRek/pLD/QFYCoUqr3/LOshOJBUW0BxA+B4lRJXf3Ssx/J/zmXOgJ3KrCu4PIC7o0X4yI4aBMYlhpyh6H88p904ApqmzvBwJpdA+IJHvK/OZiiX2+J4S0q2YiN1myuhBS14Oic9j1tjoHcopiH/rnEfUGvIEv/3SY+glnx9VFAYGYm3o6wKXWRhpVgkaCShc2AhGy4ULhjy0ys/7pymvvg6Sps5/ytdCod/jWeFatCAu/XHVKW0A3yhlETuzcg4AdsXdeiwiwVwJjCGhKGevGAVvvzvaAosHA0A/G9tdOzAZnUO8HweZ9AT2FHdbNDTpMdokCp0S+sdCNpkx60ndkThhbuhJW1X7ESnLq0vxiKOygh7H6bjOpW19+6veXrNvIOD7GNkZtVG0SgNOCbv5zZ6s2Kharj7rxjEwhn69Oi96NCBVLov+w8otp4XvO+RxSQMc= X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b2a1a528-5693-4b5a-241e-08d49e5200e0 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131430075)(201703131517081);SRVR:BLUPR03MB166; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB166;3:JxfWz1ApNd6eAk2Z5eDjLxB46WW8HidSOK7fRolN5pekInGRT92Re0x+oE2UdowpKYtG2e5hHVC0OD1gKIac4gDe/iKhEWs1K2uYV+/b+/kYnu+kUM6+l3mIqYbvKAkVp30sAbAcZsiZ58Jkog8Qw9n2FYHibK3ut11bEP+NjtFIAfBVlYQA4l9OD99HVG27QDXSY10m4XU9Bwsf7BLfgINdiVlaciB3npej4i9QmfjYna83T7ZQd6KL5bC8zR5I8nzlQ+KgIfbR5XaKOcACU2z53mUWt200MHeCxIpUvo1TQcl9DOb5+l3UICftJ8n5WzUM+cuX6SX/G3rIwoi/vtOrVXWvcX356EJ5Y/KLlKIHi2aRjSezK1plMPnN7UAVZhk2pwoUEm+qnw6Z/tKiO6MD6c5UAr9fjagqp9ZE2dcXss1cgbaMwHeSQpXHCaey;25:PPOMhtVreBwRnTSdU0hehb/NyG/JrnlFVVDnyHDi4g9r6dIE6TdtXeQz9IdlitRw6Xit6cIS63BW2ufL5gRPu89HuyZqYQXdqEuMHnlJoLU/2Skk550QvJt05IlXyNt/wN/TgGLyYsz9Njgd9zE0uKS1TzNLcHxQKqGWBVQVGpSbDNF7WhIIt7QuDns12eks4vwP/hRMWDqbrUavdulnpnQ9B2rTTRnNnSygW/zxQ30I4eYQGa7ePzw9e6MYnPTmVt4hs+YDkuOENWqPqtY3aL5XbIXh/xOI9Px2O2YpC3EX5ibfZnhKd5D/XyZUy7oHDIIixDdBJQNPbeN/tYqQ7+54veTDbIRHR7O0GFnJH5jsMX6b22Rw1MWGCaLDE6Fyhs9Jr3/+VD4ZHCcWUT/6IH1Pj+n+K1HLNYF+zXflvt+E9Vj4tZ4L4K23E02Bt/XvWnG39e+3iWIz3VsjUJBniQ== X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB166;31:BalHCfIDpCX5nw1KdtWJhDEfEJfOm4KI+KN1F84to8CTSMX+iZD26sezkwp+fvIcQhuLHYZQunkgi8GbUCpR0Qk804iFCo0eifjEbcgujtgrkaLHlh1oR/IbD0XaXSdwZcGCq7SG/ADm1ABfrLWn2IiVPIWAiKGrJcWCq6dgs9WFFlaf41LNhzedmERR0k/xspKfF+1vHLVj2ihNpQa1kHVPUJlkiNjMcMS5kxRoQRIwtZ7owpEIdgaYq2oKzRzZYLEJ04e4YytTos0WyqDy0g== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6095135)(601004)(2401047)(13024025)(13023025)(13018025)(8121501046)(5005006)(13015025)(13017025)(10201501046)(93006095)(93001095)(3002001)(6055026)(6096035)(20161123563025)(20161123565025)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259150)(20161123559100)(20161123556025)(20161123561025);SRVR:BLUPR03MB166;BCL:0;PCL:0;RULEID:(400006);SRVR:BLUPR03MB166; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB166;4:7ubwFnwn5VkJEo4yNRinmcwnRtEFF2hDmVj2TouprBm+1rm0Cx4nbxulqktSz1sIi9r4LBdNGvskPn/R1AOIRWQLorVLTqi+3/aa+gVtaCb++45cFA7aKymfeiocHc+6490Sn6kao+eT6J20XDfx0ZiMpglwkSaBEgZIAFANKplKNOvl7HWd7Zy4hhctXOh/Agx6WEv4AXGTGyjnQlHWtbbXSmPatJWcSMLF+7u2msvGFhyhmiQ9kW6tyV0ew4Gt0CAIX4gNSeifA5kbZyV7w7jyvGuP5Fnc+whMKGuPhmstBGJ7kBp2wz7xGO0jbYeyU+YiGTlX42B1Qxw7kfEjKMK65ltyu82PSBpzauo1pKiu9yni3ae7SGw0nsd8j24Zc7iI5jAwHzBul4f4Nv6UtxOvozOQViVWLvKOdiGX7PHOQQFwSTlXqHImuPAkGbYhw0kYjoWVIP2L/6j9cpX2NA6BaBTn7pgH5uVH2CTV97qXRijSW3kwBvaURYG9vPxFxuUcjmhYsLgkVkypXjv3nLbFCZU2EXQvt43UwhN0/qOnSjAXHAY0mS5Pt+3HZlEy7BtTxykS7GZYzxCdq5VAsbSXT65RP8fQK0X2GMPFLnb2ZdoDP8RHCrT9M9lnL10RIrbJlKqHL2LJOalI533gEb+IdpBPy4F3VEmClmwY+LmC+we2EjUO0HPU/mDMBrYs6CQbb2Z4NoZZ0te2QkfNtNHiq9u37wBFCi0NPkPBhRshAOLo9ALd2QMZrUydIPGpl42F2PuegJtVp0N1xCBXwDICMK23gVkxEhbZZ6GbCXjkAd6VD1UsNKGu+fTg7YCb4mbU+QN1D5xz8rbku4+rdoXhUEg1UbuOyxAkR7qJkrfdsiztnp39Dn3dEdjYdLmodedee35HmbXEN0mSPoklm08/YvRRc80QyS8Bxk7yd1Y= X-Forefront-PRVS: 031257FE13 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BLUPR03MB166;23:Uob8enw/39HBrQVGEFmtLUFymnIIY5TPenNsyF+qY3?= =?us-ascii?Q?eBUBibyWFsYxVYbiCH+7eEitvigiy2NbWWgv7WTwF0HiqzFdLCGNdpg2sNXe?= =?us-ascii?Q?17d2UWIhES0ac2LKTCmBfH7mfeZWxeVhtM2Oe7GNUUS4IDhz5LzKly5rUYlc?= =?us-ascii?Q?El+b3sgZ4CqhWYc5q1iGQT6GJJuWYG9hEx/G6rYKX1uQrbLtOZ1JCY0r8CZb?= =?us-ascii?Q?jHOKpQYcSdyrWen46MVVDrx0qjGk3Hj3mRu/fHpygfoHTbizV1AD8ZfSwO7D?= =?us-ascii?Q?pNDk7AlBY4moC+i/rSo+ROOaQRJLFXpmPdYaxkAZIzpXWpv8x+qmv++v4inn?= =?us-ascii?Q?StYoOKXtGt8WhWAn6tr6uJFTFCWEuCmgjWXZML3G4nL3a/oRXzfZOy2DhsFD?= =?us-ascii?Q?WB9rCyR9O2kAld1dgX8TnpCexMK/CFRT3B9TX27XXpWvgknZnUgXwaaPfVXM?= =?us-ascii?Q?9osYQYZInbzC4VBMzM1veOvLQL7nBsmjxomJ3fezPQn20q3ImKsyAeYarOIN?= =?us-ascii?Q?lExTtNEaz5wx2A8Sqj9G/0XYZN4DmC+LvXtv7m9Fd9dVpTJlFsAnmHVP6eLi?= =?us-ascii?Q?0cU3uZhW/XO4NL1VLC1uXR4dRoQh5OVYbAY+3Z16aQ9tt20T1JrD95eTViJ+?= =?us-ascii?Q?IaOgdTDIpCO7e80rxTOZhH0T+XvSMaEJJweZAS2IfIYl4raK3HDEd0EifGjT?= =?us-ascii?Q?OKpZ2ZCDwWD75KFnquZPorzvepxL92PBKnsLqLh0Re6mk6+9kJBCuR6iT2+O?= =?us-ascii?Q?JjoRvISK12PRjnFQd39ikk/E8msYagk730GHkZdgfc2bNmsUPHy3+R2dN1aX?= =?us-ascii?Q?H10mXDZ5rvPSv0EIWej5bt+KaglL/vkb2RTwnwvSgRCPyYwKWiWhRdM9YftO?= =?us-ascii?Q?EHJ8165R8/ikogAmgKxGf4v3Lx9f0vrztMZzKJPAy8NS9cfwEqDyM/ATx/SE?= =?us-ascii?Q?Dqw4O04LA6Nf3+McdHX/ILklR+M8RBPXsAOsG/JsCCSK2sSbi2h5V9DbQgTn?= =?us-ascii?Q?9W03WxVTLZ6t/RU7hd/RPHVgWJ/2cQYQMc2eUKmWsjWb7Xk8PosTIyFhMuWe?= =?us-ascii?Q?mQPQB7lB5bnUwZOtLayn/hxxWGop/Vr+4A6HZX/en0EwuK7yR4CrN9FHD8v8?= =?us-ascii?Q?oYQNgrlQyknfp6mlKtM5EcKLL7HzNwEA61RPhcJEbdULkcbN8Qs55S/8zgyE?= =?us-ascii?Q?klRyTX54+5iFWBNhsNQU8VF+e7fOivXoSBx2d1+YeEQtH3Gj38i8tGCEz6zu?= =?us-ascii?Q?b75/oPr3ZDf4jq58xszlwWmTtGfieoOJF/nXpsk/MIzT/qZwZCxDNKjSrZIH?= =?us-ascii?Q?YHx63LH+PUqkptN9EHMjH9W4MAZUSSycLwhG3r1QQViPI3zJEs6yle5XLslo?= =?us-ascii?Q?0UIL712M3gEWOPai7LbG30DiSBy7UBC/XP0NsM7vpC6JGvr8OdYn8nH+s5rE?= =?us-ascii?Q?Z94wWjl/GUNI3jiNBepxIluUsVYkCxKFpJSQ73ZPvOTF1/FAFydh5iqGtuLu?= =?us-ascii?Q?2RCLzu83pnfDrpRM+Uerh+F+yhRXA36d4L8/KkzcChagxhr482CbVC?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB166;6:eidpjDUnFqP7iOVL2uUsqWALLuy6Q5yxwZbLODQ9AjjqRx+H3Hey95CncGfedqCcYY9qumaQpdLX7jjB7lRC5xHULJLbcNfYxGsO8rfV6vX/JQU7uPF1jmIHlezhVu/tSXAUmKOdyK5G3m/fhfOVjvzDLRcxnkL07o3H7xEgZbEUtYA0NXtt8GVKNvgxKZFZNgn8UFVN0il/P/QoqjaSNbu0mwPXtTal94QPpRL0rn6VMjP/ag6WWToDJa4CsMRNPcAL9jnQ5zkiQ5WPnydGi6Xdz4C71eEl9fqdSpEm+EU72LAQXRAC6UbL+ntfbAcrS3pd7u3aYBnf1qvWr9YJI86kvFt5a9NrDQ52IffTqsbjcFEfWZOnIcgk7Cax/RcrlMbBNq2vGQCAPscOcUjvE1F8pyyBqvOtt1vPX0ykSLBJX1Ade+n3dNk5TM0qneoRVQdQS5rJGC/dWaTEfWjAN7IRFQa0TtAlQE5MRx64jIh3rlHcMt6yujaAUyn8nhRMAXS4phH0+Ad5a6iz79dsFg==;5:P47TftDYVL8IsFBM/yFUEmQYRry9lrXal4+CUg4wEshWRCS/gfJKx+GMxU//e0dqVBEEycQ9TpjoFxg1gPbGGkdRHbTkGkyLeG7CHB8Vh4RxsGEs90SPoHq5w6hh8k+N+b5U3D49XXwyO9j3L5TUabjR3MuxfZUY0MNMU7RoAP10siaKtNtmhL6fJHOypwWm;24:fmZRMtcWdnJl6gVj6NsGmlEPe3V3cq4CufSz8g2YFmtxveZ330zHAYHg0hzh0NDxz0ReNgmI8pr1pxYetmAz/vVcmEvRsDeOGrbEpoVhhNU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB166;7:JVGsmVBnYowcZJ/x9JxCIX7LcHeMzb7wwPu+SJQ8GzIl5D77ytR0zgV0tQSWTPxDl+hwsvheAKnxm3fv60soTipymr7/71AFVWEglC/fOSiX1jEC9Jemofa5zjV32KH5FFr/txuK26sRZjqSyyYivirmznbuH2VUmk/LVbOifg35RmV78P6FFhWuMX7h9cckWJ1/mnD5tvReNS0MFYW6iJ1TvnF/WiP5SlFIzXMNHaEMZWrjVsqqbOxR88yVYjHfKMkmBEasXokEEi5yS7p17GU0aMsPz6qd3qhGrPVjEpt+BPDiKOZR0jyM+OO1hBhJalNWKAOcAs+fG1nkW7OBaQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2017 00:57:20.3562 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB166 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 18, 2017 at 04:14:14PM +0200, Michael Thalmeier wrote: > ci_role BUGs when the role is >= CI_ROLE_END. > > Signed-off-by: Michael Thalmeier > --- > drivers/usb/chipidea/debug.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c > index 6d23eed..1c31e8a 100644 > --- a/drivers/usb/chipidea/debug.c > +++ b/drivers/usb/chipidea/debug.c > @@ -294,7 +294,8 @@ static int ci_role_show(struct seq_file *s, void *data) > { > struct ci_hdrc *ci = s->private; > > - seq_printf(s, "%s\n", ci_role(ci)->name); > + if (ci->role != CI_ROLE_END) > + seq_printf(s, "%s\n", ci_role(ci)->name); > > return 0; > } I will queue it, and cc stable -- Best Regards, Peter Chen