From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756049AbdESBye (ORCPT ); Thu, 18 May 2017 21:54:34 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:54526 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755448AbdESByc (ORCPT ); Thu, 18 May 2017 21:54:32 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9139E607F4 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Thu, 18 May 2017 18:54:30 -0700 From: Stephen Boyd To: Maxime Ripard Cc: Chen-Yu Tsai , Mike Turquette , Daniel Vetter , David Airlie , dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni Subject: Re: [PATCH v3 01/21] clk: divider: Make divider_round_rate take the parent clock Message-ID: <20170519015430.GF20170@codeaurora.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/17, Maxime Ripard wrote: > So far, divider_round_rate only considers the parent clock returned by > clk_hw_get_parent. > > This works fine on clocks that have a single parents, this doesn't work on > muxes, since we will only consider the first parent, while other parents > may totally be able to provide a better combination. > > Clocks in that case cannot use divider_round_rate, so would have to come up > with a very similar logic to work around it. Instead of having to do > something like this, and duplicate that logic everywhere, create a > divider_round_rate parent to allow caller to give an additional parameter > for the parent clock to consider. > > Reviewed-by: Chen-Yu Tsai > Signed-off-by: Maxime Ripard > --- Acked-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project