From: Vinod Koul <vinod.koul@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Colin King <colin.king@canonical.com>,
Anup Patel <anup.patel@broadcom.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: remove redundant null check on req
Date: Fri, 19 May 2017 08:52:51 +0530 [thread overview]
Message-ID: <20170519032251.GK15061@localhost> (raw)
In-Reply-To: <CAPcyv4iD5xD8E3E9+gbgmrbD+nNpXfjMqi4WzTA46H9mSv5gvQ@mail.gmail.com>
On Wed, May 17, 2017 at 12:12:00PM -0700, Dan Williams wrote:
> On Wed, May 17, 2017 at 6:35 AM, Colin King <colin.king@canonical.com> wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Req is never null on at the point of the null check, so
> > remove this redundant check and just return &req->tx.
> >
> > Detected by CoverityScan, CID#1436147 ("Logically dead code")
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Hi Colin,
>
> Looks good, can you also include the driver name in your patch subjects?
>
> For example "dmaengine, bcm-scm-raid: remove redundant null check on
> req", would make it clear that this is a driver fix and not a core
> dmaengine issue.
Yeah that would help, also do the same for static patch you sent on the
driver.
--
~Vinod
prev parent reply other threads:[~2017-05-19 3:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 13:35 [PATCH] dmaengine: remove redundant null check on req Colin King
2017-05-17 19:12 ` Dan Williams
2017-05-19 3:22 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170519032251.GK15061@localhost \
--to=vinod.koul@intel.com \
--cc=anup.patel@broadcom.com \
--cc=colin.king@canonical.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox