* [PATCH] dmaengine: remove redundant null check on req
@ 2017-05-17 13:35 Colin King
2017-05-17 19:12 ` Dan Williams
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2017-05-17 13:35 UTC (permalink / raw)
To: Anup Patel, Dan Williams, Vinod Koul, dmaengine
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Req is never null on at the point of the null check, so
remove this redundant check and just return &req->tx.
Detected by CoverityScan, CID#1436147 ("Logically dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/dma/bcm-sba-raid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c
index 7daa883eeded..8246c26eabe5 100644
--- a/drivers/dma/bcm-sba-raid.c
+++ b/drivers/dma/bcm-sba-raid.c
@@ -582,7 +582,7 @@ sba_prep_dma_interrupt(struct dma_chan *dchan, unsigned long flags)
req->tx.flags = flags;
req->tx.cookie = -EBUSY;
- return (req) ? &req->tx : NULL;
+ return &req->tx;
}
static void sba_fillup_memcpy_msg(struct sba_request *req,
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: remove redundant null check on req
2017-05-17 13:35 [PATCH] dmaengine: remove redundant null check on req Colin King
@ 2017-05-17 19:12 ` Dan Williams
2017-05-19 3:22 ` Vinod Koul
0 siblings, 1 reply; 3+ messages in thread
From: Dan Williams @ 2017-05-17 19:12 UTC (permalink / raw)
To: Colin King
Cc: Anup Patel, Vinod Koul, dmaengine@vger.kernel.org,
kernel-janitors, linux-kernel@vger.kernel.org
On Wed, May 17, 2017 at 6:35 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Req is never null on at the point of the null check, so
> remove this redundant check and just return &req->tx.
>
> Detected by CoverityScan, CID#1436147 ("Logically dead code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Hi Colin,
Looks good, can you also include the driver name in your patch subjects?
For example "dmaengine, bcm-scm-raid: remove redundant null check on
req", would make it clear that this is a driver fix and not a core
dmaengine issue.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: remove redundant null check on req
2017-05-17 19:12 ` Dan Williams
@ 2017-05-19 3:22 ` Vinod Koul
0 siblings, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2017-05-19 3:22 UTC (permalink / raw)
To: Dan Williams
Cc: Colin King, Anup Patel, dmaengine@vger.kernel.org,
kernel-janitors, linux-kernel@vger.kernel.org
On Wed, May 17, 2017 at 12:12:00PM -0700, Dan Williams wrote:
> On Wed, May 17, 2017 at 6:35 AM, Colin King <colin.king@canonical.com> wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Req is never null on at the point of the null check, so
> > remove this redundant check and just return &req->tx.
> >
> > Detected by CoverityScan, CID#1436147 ("Logically dead code")
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Hi Colin,
>
> Looks good, can you also include the driver name in your patch subjects?
>
> For example "dmaengine, bcm-scm-raid: remove redundant null check on
> req", would make it clear that this is a driver fix and not a core
> dmaengine issue.
Yeah that would help, also do the same for static patch you sent on the
driver.
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-19 3:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-17 13:35 [PATCH] dmaengine: remove redundant null check on req Colin King
2017-05-17 19:12 ` Dan Williams
2017-05-19 3:22 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox