From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755316AbdESDUm (ORCPT ); Thu, 18 May 2017 23:20:42 -0400 Received: from mga05.intel.com ([192.55.52.43]:3941 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754670AbdESDUl (ORCPT ); Thu, 18 May 2017 23:20:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,362,1491289200"; d="scan'208";a="970558869" Date: Fri, 19 May 2017 08:52:51 +0530 From: Vinod Koul To: Dan Williams Cc: Colin King , Anup Patel , "dmaengine@vger.kernel.org" , kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] dmaengine: remove redundant null check on req Message-ID: <20170519032251.GK15061@localhost> References: <20170517133549.7157-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 17, 2017 at 12:12:00PM -0700, Dan Williams wrote: > On Wed, May 17, 2017 at 6:35 AM, Colin King wrote: > > From: Colin Ian King > > > > Req is never null on at the point of the null check, so > > remove this redundant check and just return &req->tx. > > > > Detected by CoverityScan, CID#1436147 ("Logically dead code") > > > > Signed-off-by: Colin Ian King > > Hi Colin, > > Looks good, can you also include the driver name in your patch subjects? > > For example "dmaengine, bcm-scm-raid: remove redundant null check on > req", would make it clear that this is a driver fix and not a core > dmaengine issue. Yeah that would help, also do the same for static patch you sent on the driver. -- ~Vinod