From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755731AbdESDXm (ORCPT <rfc822;w@1wt.eu>);
        Thu, 18 May 2017 23:23:42 -0400
Received: from mga01.intel.com ([192.55.52.88]:58201 "EHLO mga01.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751155AbdESDXk (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 18 May 2017 23:23:40 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,362,1491289200"; 
   d="scan'208";a="89346978"
Date: Fri, 19 May 2017 08:55:50 +0530
From: Vinod Koul <vinod.koul@intel.com>
To: Colin King <colin.king@canonical.com>
Cc: Anup Patel <anup.patel@broadcom.com>,
        Dan Williams <dan.j.williams@intel.com>, dmaengine@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][V2] dmaengine: bcm-scm-raid: remove redundant null check
 on req
Message-ID: <20170519032550.GL15061@localhost>
References: <20170517215850.5077-1-colin.king@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170517215850.5077-1-colin.king@canonical.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 17, 2017 at 10:58:50PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Req is never null on at the point of the null check, so
> remove this redundant check and just return &req->tx.
> 
> Detected by CoverityScan, CID#1436147 ("Logically dead code")


Applied, thanks

-- 
~Vinod