From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755844AbdESDoE (ORCPT <rfc822;w@1wt.eu>);
        Thu, 18 May 2017 23:44:04 -0400
Received: from mga01.intel.com ([192.55.52.88]:8162 "EHLO mga01.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751071AbdESDoB (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 18 May 2017 23:44:01 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,362,1491289200"; 
   d="scan'208";a="104336018"
Date: Fri, 19 May 2017 09:16:12 +0530
From: Vinod Koul <vinod.koul@intel.com>
To: Randy Dunlap <rdunlap@infradead.org>, Arnd Bergmann <arnd@arndb.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Anup Patel <anup.patel@broadcom.com>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>
Subject: Re: [PATCH -next] dma: bcm-sba-raid: fix build errors and
 dependencies
Message-ID: <20170519034612.GM15061@localhost>
References: <e21b438b-ab97-ad1a-7108-a2b3d28283ff@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e21b438b-ab97-ad1a-7108-a2b3d28283ff@infradead.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 17, 2017 at 09:40:47AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix build errors when COMPILE_TEST is enabled but RAID6_PQ is not
> enabled (seen on x86_64).

Oops, I already applied one from Arnd and pushed that out.

> 
> drivers/built-in.o: In function `sba_prep_dma_pq_req':
> (.text+0x16132): undefined reference to `raid6_gflog'
> drivers/built-in.o: In function `sba_prep_dma_pq_single_req':
> (.text+0x162f4): undefined reference to `raid6_gflog'
> 
> This driver needs RAID6_PQ and MAILBOX (from inspection) independent of
> ARM64 or COMPILE_TEST.
> 
> However, RAID6_PQ is not defined in any Kconfig file, although it is
> used in several of them. :(
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Anup Patel <anup.patel@broadcom.com>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Cc: dmaengine@vger.kernel.org
> ---
>  drivers/dma/Kconfig |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> --- linux-next-20170517.orig/drivers/dma/Kconfig
> +++ linux-next-20170517/drivers/dma/Kconfig
> @@ -101,7 +101,8 @@ config AXI_DMAC
>  
>  config BCM_SBA_RAID
>  	tristate "Broadcom SBA RAID engine support"
> -	depends on (ARM64 && MAILBOX && RAID6_PQ) || COMPILE_TEST
> +	depends on ARM64 || COMPILE_TEST
> +	depends on MAILBOX && RAID6_PQ
>  	select DMA_ENGINE
>  	select DMA_ENGINE_RAID
>  	select ASYNC_TX_DISABLE_XOR_VAL_DMA
> 
> 

-- 
~Vinod