From: Joerg Roedel <jroedel@suse.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Magnus Damm <damm+renesas@opensource.se>,
Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/dma: fix function declaration
Date: Fri, 19 May 2017 13:33:23 +0200 [thread overview]
Message-ID: <20170519113323.GK20382@suse.de> (raw)
In-Reply-To: <20170518132402.1355029-1-arnd@arndb.de>
On Thu, May 18, 2017 at 03:13:57PM +0200, Arnd Bergmann wrote:
> Newly added code in the ipmmu-vmsa driver showed a small mistake
> in a header file that can't be included by itself without CONFIG_IOMMU_DMA
> enabled:
>
> In file included from drivers/iommu/ipmmu-vmsa.c:13:0:
> include/linux/dma-iommu.h:105:94: error: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>
> This adds a forward declaration for 'struct device', similar to how
> we treat the other struct types in this case.
>
> Fixes: 3ae47292024f ("iommu/ipmmu-vmsa: Add new IOMMU_DOMAIN_DMA ops")
> Fixes: 273df9635385 ("iommu/dma: Make PCI window reservation generic")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks.
prev parent reply other threads:[~2017-05-19 11:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 13:13 [PATCH] iommu/dma: fix function declaration Arnd Bergmann
2017-05-18 14:18 ` Robin Murphy
2017-05-19 11:33 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170519113323.GK20382@suse.de \
--to=jroedel@suse.de \
--cc=arnd@arndb.de \
--cc=damm+renesas@opensource.se \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox