From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755373AbdESLd3 (ORCPT ); Fri, 19 May 2017 07:33:29 -0400 Received: from mx2.suse.de ([195.135.220.15]:32888 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755183AbdESLd1 (ORCPT ); Fri, 19 May 2017 07:33:27 -0400 Date: Fri, 19 May 2017 13:33:23 +0200 From: Joerg Roedel To: Arnd Bergmann Cc: Magnus Damm , Robin Murphy , Will Deacon , linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/dma: fix function declaration Message-ID: <20170519113323.GK20382@suse.de> References: <20170518132402.1355029-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170518132402.1355029-1-arnd@arndb.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 18, 2017 at 03:13:57PM +0200, Arnd Bergmann wrote: > Newly added code in the ipmmu-vmsa driver showed a small mistake > in a header file that can't be included by itself without CONFIG_IOMMU_DMA > enabled: > > In file included from drivers/iommu/ipmmu-vmsa.c:13:0: > include/linux/dma-iommu.h:105:94: error: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] > > This adds a forward declaration for 'struct device', similar to how > we treat the other struct types in this case. > > Fixes: 3ae47292024f ("iommu/ipmmu-vmsa: Add new IOMMU_DOMAIN_DMA ops") > Fixes: 273df9635385 ("iommu/dma: Make PCI window reservation generic") > Signed-off-by: Arnd Bergmann Applied, thanks.