From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755037AbdESNFp (ORCPT ); Fri, 19 May 2017 09:05:45 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:35165 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751155AbdESNFl (ORCPT ); Fri, 19 May 2017 09:05:41 -0400 Date: Fri, 19 May 2017 06:05:41 -0700 From: Christoph Hellwig To: Qing Huang Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, dledford@redhat.com, sean.hefty@intel.com, artemyko@mellanox.com, linux-mm@kvack.org Subject: Re: [PATCH] ib/core: not to set page dirty bit if it's already set. Message-ID: <20170519130541.GA8017@infradead.org> References: <20170518233353.14370-1-qing.huang@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170518233353.14370-1-qing.huang@oracle.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 18, 2017 at 04:33:53PM -0700, Qing Huang wrote: > This change will optimize kernel memory deregistration operations. > __ib_umem_release() used to call set_page_dirty_lock() against every > writable page in its memory region. Its purpose is to keep data > synced between CPU and DMA device when swapping happens after mem > deregistration ops. Now we choose not to set page dirty bit if it's > already set by kernel prior to calling __ib_umem_release(). This > reduces memory deregistration time by half or even more when we ran > application simulation test program. As far as I can tell this code doesn't even need set_page_dirty_lock and could just use set_page_dirty > > Signed-off-by: Qing Huang > --- > drivers/infiniband/core/umem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/core/umem.c b/drivers/infiniband/core/umem.c > index 3dbf811..21e60b1 100644 > --- a/drivers/infiniband/core/umem.c > +++ b/drivers/infiniband/core/umem.c > @@ -58,7 +58,7 @@ static void __ib_umem_release(struct ib_device *dev, struct ib_umem *umem, int d > for_each_sg(umem->sg_head.sgl, sg, umem->npages, i) { > > page = sg_page(sg); > - if (umem->writable && dirty) > + if (!PageDirty(page) && umem->writable && dirty) > set_page_dirty_lock(page); > put_page(page); > } > -- > 2.9.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ---end quoted text---