From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <keith.busch@intel.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Andy Lutomirski <luto@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Sagi Grimberg <sagi@grimberg.me>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-nvme <linux-nvme@lists.infradead.org>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Mario Limonciello <mario_limonciello@dell.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme: Change our APST table to be no more aggressive than Intel RSTe
Date: Fri, 19 May 2017 16:15:22 +0200 [thread overview]
Message-ID: <20170519141522.GA1830@lst.de> (raw)
In-Reply-To: <20170519141834.GB6015@localhost.localdomain>
On Fri, May 19, 2017 at 10:18:34AM -0400, Keith Busch wrote:
> +
> + if (ns->ctrl->quirks & NVME_QUIRK_PAGE_ALIGN)
> + blk_queue_logical_block_size(ns->queue, ns->ctrl->page_size);
> + else
> + blk_queue_logical_block_size(ns->queue, bs);
Ugg. That will invalidate the layout of any existing fs (in case the
device hasn't eaten it yet). It would also invalidate things like
partitions tables, even if they are only used to share with windows.
next prev parent reply other threads:[~2017-05-19 14:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 4:06 [PATCH] nvme: Change our APST table to be no more aggressive than Intel RSTe Andy Lutomirski
2017-05-12 13:58 ` Mario.Limonciello
2017-05-12 14:04 ` Andy Lutomirski
2017-05-12 14:34 ` Mario.Limonciello
2017-05-12 23:49 ` Andy Lutomirski
2017-05-15 15:51 ` Mario.Limonciello
2017-05-13 12:27 ` Andy Lutomirski
2017-05-15 16:11 ` Mario.Limonciello
2017-05-19 1:18 ` Andy Lutomirski
2017-05-19 1:13 ` Andy Lutomirski
2017-05-19 1:32 ` Mario.Limonciello
2017-05-19 1:37 ` Andy Lutomirski
2017-05-19 6:35 ` Christoph Hellwig
2017-05-19 14:18 ` Keith Busch
2017-05-19 14:15 ` Christoph Hellwig [this message]
2017-05-19 18:24 ` Andy Lutomirski
2017-05-19 21:42 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170519141522.GA1830@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=kai.heng.feng@canonical.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=luto@kernel.org \
--cc=mario_limonciello@dell.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox