From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755381AbdESOP0 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 19 May 2017 10:15:26 -0400
Received: from verein.lst.de ([213.95.11.211]:36953 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751406AbdESOPX (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 19 May 2017 10:15:23 -0400
Date: Fri, 19 May 2017 16:15:22 +0200
From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <keith.busch@intel.com>
Cc: Christoph Hellwig <hch@infradead.org>,
        Andy Lutomirski <luto@kernel.org>, Jens Axboe <axboe@kernel.dk>,
        Sagi Grimberg <sagi@grimberg.me>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-nvme <linux-nvme@lists.infradead.org>,
        Kai-Heng Feng <kai.heng.feng@canonical.com>,
        Mario Limonciello <mario_limonciello@dell.com>,
        Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme: Change our APST table to be no more aggressive
        than Intel RSTe
Message-ID: <20170519141522.GA1830@lst.de>
References: <ddc5be5d81966effaf73e3cee54330c351bc8169.1494561654.git.luto@kernel.org> <CALCETrUYutdtp5U7oYwf7-eNuB0MrwoC18mG5-S8iOP4ZEVDuA@mail.gmail.com> <20170519063505.GA15980@infradead.org> <20170519141834.GB6015@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170519141834.GB6015@localhost.localdomain>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 19, 2017 at 10:18:34AM -0400, Keith Busch wrote:
> +
> +	if (ns->ctrl->quirks & NVME_QUIRK_PAGE_ALIGN)
> +		blk_queue_logical_block_size(ns->queue, ns->ctrl->page_size);
> +	else
> +		blk_queue_logical_block_size(ns->queue, bs);

Ugg.  That will invalidate the layout of any existing fs (in case the
device hasn't eaten it yet).  It would also invalidate things like
partitions tables, even if they are only used to share with windows.