From: Al Viro <viro@ZenIV.linux.org.uk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Geliang Tang" <geliangtang@gmail.com>,
"Felipe Balbi" <balbi@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Michal Nazarewicz" <mina86@mina86.com>,
"Vincent Pelletier" <plr.vincent@gmail.com>,
"Felix Hädicke" <felixhaedicke@web.de>,
"Jim Lin" <jilin@nvidia.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: f_fs: use memdup_user
Date: Sun, 21 May 2017 04:25:10 +0100 [thread overview]
Message-ID: <20170521032453.GW390@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20170513080530.2rsqs3apd6w3psve@mwanda>
On Sat, May 13, 2017 at 11:05:30AM +0300, Dan Carpenter wrote:
> > + data = memdup_user(buf, len);
> > + if (unlikely(IS_ERR(data)))
>
> Don't use likely/unlikely() here. It's not a fast path.
More to the point,
#define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO)
static inline bool __must_check IS_ERR(__force const void *ptr)
{
return IS_ERR_VALUE((unsigned long)ptr);
}
IOW, IS_ERR() already produces unlikely(....), fast path or not.
next prev parent reply other threads:[~2017-05-21 3:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-13 3:15 [PATCH] KEYS: use memdup_user Geliang Tang
2017-05-13 3:15 ` [PATCH] mmc: block: " Geliang Tang
2017-05-19 7:43 ` Ulf Hansson
2017-05-13 3:15 ` [PATCH] usb: gadget: f_fs: " Geliang Tang
2017-05-13 8:05 ` Dan Carpenter
2017-05-21 3:25 ` Al Viro [this message]
2017-05-14 11:33 ` Michal Nazarewicz
2017-05-13 3:16 ` [PATCH] USB: iowarrior: " Geliang Tang
2017-05-15 10:14 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170521032453.GW390@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=balbi@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=felixhaedicke@web.de \
--cc=geliangtang@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jilin@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mina86@mina86.com \
--cc=plr.vincent@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox