From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751126AbdEUGJQ (ORCPT ); Sun, 21 May 2017 02:09:16 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:33827 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750786AbdEUGJO (ORCPT ); Sun, 21 May 2017 02:09:14 -0400 Date: Sat, 20 May 2017 23:09:02 -0700 From: Christoph Hellwig To: Okash Khawaja Cc: Greg Kroah-Hartman , Jiri Slaby , Samuel Thibault , linux-kernel@vger.kernel.org, William Hubbs , Chris Brannon , Kirk Reiser , speakup@linux-speakup.org, devel@driverdev.osuosl.org, Alan Cox Subject: Re: [patch v2 1/6] tty: export tty_open_by_driver Message-ID: <20170521060902.GA32641@infradead.org> References: <20170515174531.968330974@gmail.com> <20170515175611.655323933@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170515175611.655323933@gmail.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 15, 2017 at 06:45:32PM +0100, Okash Khawaja wrote: > This exports tty_open_by_driver so that it can be called from other places inside the kernel. The checks for null file pointer are based on Alan Cox's patch here: http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1215095.html. Description below is quoted from it: Any non-staging users? Please don't add new APIs with proper in-kernel users (and staging doesn't count for that).