From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Okash Khawaja <okash.khawaja@gmail.com>,
devel@driverdev.osuosl.org, Kirk Reiser <kirk@reisers.ca>,
speakup@linux-speakup.org, linux-kernel@vger.kernel.org,
Jiri Slaby <jslaby@suse.com>,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
Chris Brannon <chris@the-brannons.com>
Subject: Re: [patch v2 1/6] tty: export tty_open_by_driver
Date: Sun, 21 May 2017 09:43:50 +0200 [thread overview]
Message-ID: <20170521074350.GB3962@kroah.com> (raw)
In-Reply-To: <20170521060902.GA32641@infradead.org>
On Sat, May 20, 2017 at 11:09:02PM -0700, Christoph Hellwig wrote:
> On Mon, May 15, 2017 at 06:45:32PM +0100, Okash Khawaja wrote:
> > This exports tty_open_by_driver so that it can be called from other places inside the kernel. The checks for null file pointer are based on Alan Cox's patch here: http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1215095.html. Description below is quoted from it:
>
> Any non-staging users? Please don't add new APIs with proper in-kernel
> users (and staging doesn't count for that).
I'll give the speakup code a pass here, as they are trying to get this
cleaned up properly and moved into the correct location. It's almost
ready, with this and the serdev interface, it should be pretty close...
thanks,
greg k-h
next prev parent reply other threads:[~2017-05-21 7:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 17:45 [patch v2 0/6] staging: speakup: migrate synths to use TTY-based comms Okash Khawaja
2017-05-15 17:45 ` [patch v2 1/6] tty: export tty_open_by_driver Okash Khawaja
2017-05-21 6:09 ` Christoph Hellwig
2017-05-21 7:43 ` Greg Kroah-Hartman [this message]
2017-05-15 17:45 ` [patch v2 2/6] staging: speakup: add tty-based comms functions Okash Khawaja
2017-05-15 17:45 ` [patch v2 3/6] staging: speakup: migrate acntsa, bns, dummy and txprt to ttyio Okash Khawaja
2017-05-15 17:45 ` [patch v2 4/6] staging: speakup: add send_xchar, tiocmset and input functionality for tty Okash Khawaja
2017-05-15 17:45 ` [patch v2 5/6] staging: speakup: migrate apollo, ltlk, audptr, decext, dectlk and spkout Okash Khawaja
2017-05-15 17:45 ` [patch v2 6/6] staging: speakup: flush tty buffers and ensure hardware flow control Okash Khawaja
2017-05-16 12:00 ` Greg Kroah-Hartman
2017-05-16 12:19 ` Okash Khawaja
2017-05-16 12:28 ` Greg Kroah-Hartman
2017-05-16 12:51 ` Okash Khawaja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170521074350.GB3962@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=hch@infradead.org \
--cc=jslaby@suse.com \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=okash.khawaja@gmail.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox