From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751518AbdEUIcj (ORCPT ); Sun, 21 May 2017 04:32:39 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:52999 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750860AbdEUIci (ORCPT ); Sun, 21 May 2017 04:32:38 -0400 Date: Sun, 21 May 2017 01:32:34 -0700 From: Christoph Hellwig To: Gabriele Paoloni Cc: bhelgaas@google.com, helgaas@kernel.org, linuxarm@huawei.com, linux-pci@vger.kernel.org, lukas@wunner.de, linux-kernel@vger.kernel.org, mika.westerberg@linux.intel.com, hch@infradead.org, liudongdong3@huawei.com Subject: Re: [PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services Message-ID: <20170521083234.GA20658@infradead.org> References: <1495103748-7876-1-git-send-email-gabriele.paoloni@huawei.com> <1495103748-7876-2-git-send-email-gabriele.paoloni@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1495103748-7876-2-git-send-email-gabriele.paoloni@huawei.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + * > + * pci_irq_vector() below is able to handle entry differently > + * depending on MSI vs MSI-x case > + * > */ One more instance of this comment left :) > pcie_capability_read_word(dev, PCI_EXP_FLAGS, ®16); > entry = (reg16 & PCI_EXP_FLAGS_IRQ) >> 9; > @@ -100,7 +107,10 @@ static int pcie_port_enable_msix(struct pci_dev *dev, int *irqs, int mask) > * MSI/MSI-X vectors assigned to the port is going to be used > * for AER, where "For MSI-X, the value in this register > * indicates which MSI-X Table entry is used to generate the > - * interrupt message." > + * interrupt message." and "For MSI, the value > + * in this field indicates the offset between the base Message > + * Data and the interrupt message that is generated." > + * > */ And while this is getting a little too deep into nitpicking: we usually don't add empty lines to the end of comments.