From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756928AbdEUVO4 (ORCPT <rfc822;w@1wt.eu>);
        Sun, 21 May 2017 17:14:56 -0400
Received: from zeniv.linux.org.uk ([195.92.253.2]:50820 "EHLO
        ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1756695AbdEUVOy (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 21 May 2017 17:14:54 -0400
Date: Sun, 21 May 2017 22:14:43 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: kernel test robot <xiaolong.ye@intel.com>,
        linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
        Oleg Nesterov <oleg@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
        Christoph Hellwig <hch@lst.de>, lkp@01.org
Subject: Re: [lkp-robot] [waitid()]  75f64d68f9:
 Kernel_panic-not_syncing:Attempted_to_kill_init!exitcode=
Message-ID: <20170521211443.GA390@ZenIV.linux.org.uk>
References: <20170515223716.2085-8-viro@ZenIV.linux.org.uk>
 <20170519060820.GW568@yexl-desktop>
 <20170521073405.GX390@ZenIV.linux.org.uk>
 <alpine.LFD.2.20.1705211233580.8607@i7.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.LFD.2.20.1705211233580.8607@i7.lan>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, May 21, 2017 at 12:35:28PM -0700, Linus Torvalds wrote:
> 
> 
> On Sun, 21 May 2017, Al Viro wrote:
> > 
> > fix unsafe_put_user()
> 
> So here's my proposed patch on top of yours to fix unsafe_get_user() with 
> "long long" arguments, and to clean up the extra-long line you did.
> 
> Comments?

>  #define unsafe_get_user(x, ptr, err_label)					\
>  do {										\
>  	int __gu_err;								\
> -	unsigned long __gu_val;							\
> +	__inttype(*(ptr)) __gu_val;						\

Umm...  get_user() for anything larger than long is simply not supported on
a lot of architectures[1].  Do we really want to do that for unsafe_get_user()?

[1] at the moment, blackfin, m32r, m68k/mmu, microblaze, mn10300, nios2, sh.
arm allows it for get_user() (and rmk was really unhappy about doing so), but
not for __get_user().