From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935211AbdEVO5A (ORCPT ); Mon, 22 May 2017 10:57:00 -0400 Received: from muru.com ([72.249.23.125]:48702 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934539AbdEVO47 (ORCPT ); Mon, 22 May 2017 10:56:59 -0400 Date: Mon, 22 May 2017 07:56:54 -0700 From: Tony Lindgren To: Russell King Cc: Santosh Shilimkar , Russell King , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Keerthy J , Dave Gerlach Subject: Re: [PATCH v2 3/5] ARM: OMAP2+: pm33xx-core: Add platform code needed for PM Message-ID: <20170522145654.GQ10472@atomide.com> References: <20170519200438.9502-1-d-gerlach@ti.com> <20170519200438.9502-4-d-gerlach@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170519200438.9502-4-d-gerlach@ti.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, * Dave Gerlach [170519 13:08]: > In addition to this, to be able to share data structures between C and > the sleep33xx and sleep43xx assembly code, we can automatically generate > all of the C struct member offsets and sizes as macros by making use of > the ARM asm-offsets file. In the same header that we define our data > structures in we also define all the macros in an inline function and by > adding a call to this in the asm_offsets file all macros are properly > generated and available to the assembly code without cluttering up the > asm-offsets file. ... > diff --git a/arch/arm/kernel/asm-offsets.c b/arch/arm/kernel/asm-offsets.c > index d728b5660e36..62253e7bfac4 100644 > --- a/arch/arm/kernel/asm-offsets.c > +++ b/arch/arm/kernel/asm-offsets.c > @@ -28,6 +28,7 @@ > #include > #include > #include > +#include > #include > > /* > @@ -187,6 +188,7 @@ int main(void) > #if defined(CONFIG_SOC_AM33XX) || defined(CONFIG_SOC_AM43XX) > BLANK(); > ti_emif_offsets(); > + amx3_pm_asm_offsets(); > #endif > > return 0; Russell, care to take a look at the above if you're OK with it or if you prefer to do it some other way? Also please see thread "[PATCH v2 0/2] memory: Introduce ti-emif-sram driver" for similar changes. Thanks, Tony