From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964806AbdEVPTV (ORCPT ); Mon, 22 May 2017 11:19:21 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:38594 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934647AbdEVPTT (ORCPT ); Mon, 22 May 2017 11:19:19 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2E18C60AC8 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [v4] brcmfmac: btcoex: replace init_timer with setup_timer From: Kalle Valo In-Reply-To: <20170512093259.28479-1-cheerx1994@gmail.com> References: <20170512093259.28479-1-cheerx1994@gmail.com> To: Xie Qirong Cc: Arend van Spriel , Franky Lin , Hante Meuleman , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Xie Qirong User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20170522151918.8DF6E60AC8@smtp.codeaurora.org> Date: Mon, 22 May 2017 15:19:18 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Xie Qirong wrote: > setup_timer.cocci suggested the following improvement: > drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:383:1-11: Use > setup_timer function for function on line 384. > > The combination of init_timer and setting up the data and function field > manually is equivalent to calling setup_timer(). This is an api > consolidation only and improves readability. > > Acked-by: Arend van Spriel > Signed-off-by: Xie Qirong Patch applied to wireless-drivers-next.git, thanks. 6572e5f72d01 brcmfmac: btcoex: replace init_timer with setup_timer -- https://patchwork.kernel.org/patch/9723793/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches