From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964827AbdEVPWU (ORCPT ); Mon, 22 May 2017 11:22:20 -0400 Received: from mx2.suse.de ([195.135.220.15]:47482 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934647AbdEVPWS (ORCPT ); Mon, 22 May 2017 11:22:18 -0400 Date: Mon, 22 May 2017 17:22:11 +0200 From: Petr Mladek To: Nicolas Iooss Cc: Sergey Senozhatsky , Steven Rostedt , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] printk: add __printf attributes to internal functions Message-ID: <20170522152211.GF12489@pathway.suse.cz> References: <20170520091853.26643-1-nicolas.iooss_linux@m4x.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170520091853.26643-1-nicolas.iooss_linux@m4x.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat 2017-05-20 11:18:53, Nicolas Iooss wrote: > When compiling with -Wsuggest-attribute=format, gcc complains that some > functions in kernel/printk/printk_safe.c transmit their argument to > printf-like functions without having a printf attribute. Silence these > warnings by adding relevant __printf attributes. > > Signed-off-by: Nicolas Iooss > --- > kernel/printk/printk_safe.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/kernel/printk/printk_safe.c b/kernel/printk/printk_safe.c > index 033e50a7d706..2e27a31941f4 100644 > --- a/kernel/printk/printk_safe.c > +++ b/kernel/printk/printk_safe.c > @@ -80,8 +80,8 @@ static void queue_flush_work(struct printk_safe_seq_buf *s) > * happen, printk_safe_log_store() will notice the buffer->len mismatch > * and repeat the write. > */ > -static int printk_safe_log_store(struct printk_safe_seq_buf *s, > - const char *fmt, va_list args) > +static __printf(2, 0) int printk_safe_log_store(struct printk_safe_seq_buf *s, > + const char *fmt, va_list args) > { > int add; > size_t len; > @@ -299,7 +299,7 @@ void printk_safe_flush_on_panic(void) > * one writer running. But the buffer might get flushed from another > * CPU, so we need to be careful. > */ > -static int vprintk_nmi(const char *fmt, va_list args) > +static __printf(1, 0) int vprintk_nmi(const char *fmt, va_list args) There is one more variant of this function used when CONFIG_PRINTK_NMI is not defined. Feel free to send updated patch as a reply. Or I could add this trivial change when pushing this patch to printk.git if nobody complains. Otherwise, the patch looks fine to me. Therefore with patching the other vprintk_nmi() variant: Acked-by: Petr Mladek Best Regards, Petr