From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761765AbdEVTup (ORCPT ); Mon, 22 May 2017 15:50:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37780 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750885AbdEVTun (ORCPT ); Mon, 22 May 2017 15:50:43 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C438680F94 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=marcelo.leitner@gmail.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C438680F94 Date: Mon, 22 May 2017 16:50:38 -0300 From: Marcelo Ricardo Leitner To: SF Markus Elfring Cc: linux-sctp@vger.kernel.org, netdev@vger.kernel.org, "David S. Miller" , Neil Horman , Vlad Yasevich , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 2/5] sctp: Delete an error message for a failed memory allocation in sctp_init() Message-ID: <20170522195038.GB4642@localhost.localdomain> References: <2845df67-d35d-536a-0a53-b2eb83fe1ba5@users.sourceforge.net> <7db0cb49-109b-88a6-532f-c591cc8ffa85@users.sourceforge.net> <20170522165658.GA4642@localhost.localdomain> <2c849843-549f-419e-2326-1fcb7bcdc2e2@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2c849843-549f-419e-2326-1fcb7bcdc2e2@users.sourceforge.net> User-Agent: Mutt/1.8.0 (2017-02-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 22 May 2017 19:50:43 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 22, 2017 at 09:46:21PM +0200, SF Markus Elfring wrote: > >> +++ b/net/sctp/protocol.c > >> @@ -1447,5 +1447,4 @@ static __init int sctp_init(void) > >> if (!sctp_ep_hashtable) { > >> - pr_err("Failed endpoint_hash alloc\n"); > > > > Okay but then why not also delete the one a few lines below this one: > > if (!sctp_port_hashtable) { > > pr_err("Failed bind hash alloc\n"); > > status = -ENOMEM; > > goto err_bhash_alloc; > > } > > Seems the same pattern to me. > > > >> status = -ENOMEM; > >> goto err_ehash_alloc; > >> } > > How do you think about to remove the other error message in another > update step if a consensus would be achieved in such a direction > for this software module? Fine by me. Regards, Marcelo