From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763459AbdEWAz7 (ORCPT ); Mon, 22 May 2017 20:55:59 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:44028 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752580AbdEWAz4 (ORCPT ); Mon, 22 May 2017 20:55:56 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C18C360CE0 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Mon, 22 May 2017 17:55:53 -0700 From: Stephen Boyd To: Arnd Bergmann Cc: Maxime Ripard , Chen-Yu Tsai , Michael Turquette , Icenowy Zheng , Tobias Regnery , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: sunxi-ng: select SUNXI_CCU_MULT for sun8i-a83t Message-ID: <20170523005553.GH20170@codeaurora.org> References: <20170522202951.2896280-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170522202951.2896280-1-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/22, Arnd Bergmann wrote: > We get a link error when CCU_MULT is not set with the > newly added driver: > > drivers/clk/sunxi-ng/ccu-sun8i-a83t.o:(.data.__compound_literal.1+0x4): undefined reference to `ccu_mult_ops' > drivers/clk/sunxi-ng/ccu-sun8i-a83t.o:(.data.__compound_literal.3+0x4): undefined reference to `ccu_mult_ops' > > Fixes: 46b492116666 ("clk: sunxi-ng: Add driver for A83T CCU") > Signed-off-by: Arnd Bergmann Is there any way we can automate finding these build errors and prevent them from creeping into the tree? It may be asking too much, but it seems like we should be able to find these particular problems with some script that greps for ccu_*_ops and checks that any file's Kconfig symbol also has that selected. Anyway, I'm just tired of seeing these sorts of things in my inbox. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project