From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965171AbdEWB6A (ORCPT ); Mon, 22 May 2017 21:58:00 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:40608 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752309AbdEWB56 (ORCPT ); Mon, 22 May 2017 21:57:58 -0400 Date: Tue, 23 May 2017 03:57:23 +0200 From: Andrew Lunn To: Chris Packham Cc: "linux-mtd@lists.infradead.org" , "computersforpeace@gmail.com" , "dwmw2@infradead.org" , "boris.brezillon@free-electrons.com" , "linux-kernel@vger.kernel.org" , Marek Vasut , Richard Weinberger , Cyrille Pitchen , Rob Herring , Mark Rutland , "devicetree@vger.kernel.org" Subject: Re: [PATCH v3 5/5] mtd: mchp23k256: Add support for mchp23lcv1024 Message-ID: <20170523015723.GL13759@lunn.ch> References: <20170523004317.16908-1-chris.packham@alliedtelesis.co.nz> <20170523004317.16908-6-chris.packham@alliedtelesis.co.nz> <20170523005845.GI13759@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Agreed. How about this revised commit message > > --- 8< --- > mtd: mchp23k256: Add support for mchp23lcv1024 > > The mchp23lcv1024 is similar to the mchp23k256, the differences (from a > software point of view) are the capacity of the chip and the size of the > addresses used. > > There is no way to detect the specific chip so we must be told via a > Device Tree or default to mchp23k256 when device tree is not used. > > Signed-off-by: Chris Packham > Reviewed-by: Andrew Lunn > --- >8 --- Yes, that is good. > Can someone fixup the commit message or should I re-send? The less the maintainer has to do, the more likely he will do it. But hold on a few days, and see if you get any more comments. Andrew