From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966406AbdEWHZX (ORCPT ); Tue, 23 May 2017 03:25:23 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34361 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752082AbdEWHZM (ORCPT ); Tue, 23 May 2017 03:25:12 -0400 Date: Tue, 23 May 2017 09:25:08 +0200 From: Ingo Molnar To: Frederic Weisbecker Cc: LKML , Peter Zijlstra , Rik van Riel , James Hartsock , Thomas Gleixner , stable@vger.kernel.org, Tim Wright , Pavel Machek Subject: Re: [PATCH 0/2] nohz: Deal with clock reprogram skipping issues v3 Message-ID: <20170523072508.3bzyipgwnyjcbef6@gmail.com> References: <1495201910-12466-1-git-send-email-fweisbec@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1495201910-12466-1-git-send-email-fweisbec@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Frederic Weisbecker wrote: > v2 had issues on -tip tree and triggered a warning. It seems to have > disappeared. Perhaps it was due to another timer issue. Anyway this > version brings more debugging informations, with a layout that is more > bisection-friendly and it also handles ticks that fire outside IRQ > context and thus carry NULL irq regs. This happen when > hrtimer_interrupt() is called on hotplug cpu down for example. > > We'll see if the issue arises again. > > git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git > nohz/fixes > > HEAD: cd15f46b284f04dbedd065a9d99a4e0badae379a > > Thanks, > Frederic > --- > > Frederic Weisbecker (2): > nohz: Add hrtimer sanity check > nohz: Fix collision between tick and other hrtimers, again > > > kernel/time/tick-sched.c | 48 +++++++++++++++++++++++++++++++++++++++++++----- > kernel/time/tick-sched.h | 2 ++ > 2 files changed, 45 insertions(+), 5 deletions(-) So I think the 3 commits queued up right now: 99fa871820cf: nohz: Reset next_tick cache even when the timer has no regs 411fe24e6b7c: nohz: Fix collision between tick and other hrtimers, again ce6cf9a15d62: nohz: Add hrtimer sanity check are OK and I'd not rebase them unless there's some breakage. One thing I noticed: your second series does appear to have: 99fa871820cf: nohz: Reset next_tick cache even when the timer has no regs is that intentional? That is pretty much the only commit I'd love to rebase with a proper description added. Thanks, Ingo