From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966518AbdEWHlP (ORCPT ); Tue, 23 May 2017 03:41:15 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:57580 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933857AbdEWHlM (ORCPT ); Tue, 23 May 2017 03:41:12 -0400 Date: Tue, 23 May 2017 00:41:12 -0700 From: Christoph Hellwig To: Shaohua Li Cc: linux-kernel@vger.kernel.org, tj@kernel.org, gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk, Kernel-team@fb.com Subject: Re: [PATCH 1/5] kernfs: implement i_generation Message-ID: <20170523074112.GD29525@infradead.org> References: <1840aeeff2e745d223b01514a433b4b7f20040a6.1495490800.git.shli@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1840aeeff2e745d223b01514a433b4b7f20040a6.1495490800.git.shli@fb.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 22, 2017 at 03:53:05PM -0700, Shaohua Li wrote: > Set i_generation for kernfs inod. This is required to implement exportfs > operations. > > Signed-off-by: Shaohua Li > --- > fs/kernfs/dir.c | 2 ++ > fs/kernfs/inode.c | 1 + > include/linux/kernfs.h | 2 ++ > 3 files changed, 5 insertions(+) > > diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c > index db5900aaa..09d093e 100644 > --- a/fs/kernfs/dir.c > +++ b/fs/kernfs/dir.c > @@ -634,6 +634,7 @@ static struct kernfs_node *__kernfs_new_node(struct kernfs_root *root, > if (ret < 0) > goto err_out2; > kn->ino = ret; > + kn->generation = atomic_inc_return(&root->next_generation); i_generation is only supposed to be valid on a per-inode basis, so this global counter seems really odd.