From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759667AbdEWIdp (ORCPT ); Tue, 23 May 2017 04:33:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60998 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757805AbdEWIdk (ORCPT ); Tue, 23 May 2017 04:33:40 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3B177C059730 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=benjamin.tissoires@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 3B177C059730 Date: Tue, 23 May 2017 10:33:32 +0200 From: Benjamin Tissoires To: Dmitry Torokhov Cc: Pascal Wichmann , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [4.12 regression] Thinkpad X250 Touchpad and Trackpoint not recognized anymore; commit e839ffa: "Input: synaptics - add support for Intertouch devices" Message-ID: <20170523083331.GA13096@mail.corp.redhat.com> References: <41de7f92-8d98-3266-5d28-28ba48c5da38@pa-w.de> <20170519202303.GA19281@dtor-ws> <20170519204914.GD19281@dtor-ws> <59adce69-743d-98f1-ece7-1197c49e1b5e@pa-w.de> <20170520095950.GB6808@mail.corp.redhat.com> <20170520173526.GB38800@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170520173526.GB38800@dtor-ws> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 23 May 2017 08:33:40 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On May 20 2017 or thereabouts, Dmitry Torokhov wrote: > On Sat, May 20, 2017 at 11:59:50AM +0200, Benjamin Tissoires wrote: > > Hi, > > > > On May 20 2017 or thereabouts, Pascal Wichmann wrote: > > > > Looks like you running your patched kernel? > > > That's right. > > > > > > > > > >>> CONFIG_RMI4_CORE=m > > > >>> CONFIG_RMI4_I2C=m > > > >>> CONFIG_RMI4_SPI=m > > > >>> # CONFIG_RMI4_SMB is not set > > > > > > > > This is your issue I believe. > > > > > > Indeed, enabling that configuration solves that issue. > > > > > > However, I think it is quite unintuitive that a module (psmouse) chooses > > > a default mode which requires another driver which is not necessarily > > > included; though it would probably be not a very clean solution to > > > explicitly check that as well. > > > > > > Is this behaviour, that one module requires another without > > > communicating that clearly, wanted? > > > > > > > I can see 3 solutions: > > 1. Have PS2_SMBUS depending on RMI_SMBUS (and ELAN_I2C, and others when > > required) > > 2. Have PS2_SMBUS selecting RMI_SMBUS (and the others when time comes) > > 3. Changing the default value of synaptics_intertouch to > > SYNAPTICS_INTERTOUCH_OFF when RMI_SMBUS is not set > > > > Solution 3. might be interesting because it doesn't prevent users to > > compile the module on the side and is Synaptics only. > > > > Dmitry, any comments? > > I like #3. We might also want to stick a warning into synaptics.c when > we see a device that has intertouch, but RMI_SMBUS is disabled, so we > could nudge users to switch over to RMI. > OK, thanks. See the following series that should have all of this. Cheers, Benjamin