From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936627AbdEWIjo (ORCPT ); Tue, 23 May 2017 04:39:44 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:42059 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934566AbdEWIjk (ORCPT ); Tue, 23 May 2017 04:39:40 -0400 Date: Tue, 23 May 2017 01:39:32 -0700 From: Christoph Hellwig To: Richard Weinberger Cc: linux-mtd@lists.infradead.org, david@sigma-star.at, dedekind1@gmail.com, adrian.hunter@intel.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, adilger.kernel@dilger.ca, akpm@linux-foundation.org, linux-ext4@vger.kernel.org, bfields@redhat.com, marcus.folkesson@gmail.com, hyc.lee@gmail.com, rockdotlee@gmail.com, leon.pollak@gmail.com Subject: Re: [PATCH 5/6] ubifs: Implement export_operations Message-ID: <20170523083932.GC4107@infradead.org> References: <1495398051-4604-1-git-send-email-richard@nod.at> <1495398051-4604-6-git-send-email-richard@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1495398051-4604-6-git-send-email-richard@nod.at> User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static struct inode *ubifs_nfs_get_inode(struct super_block *sb, uint64_t ino, > + uint32_t generation) > +{ > + return ubifs_iget(sb, ino); > +} You need to maintain and check an inode generation counter for this to be safe.