From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S937434AbdEWOeE (ORCPT <rfc822;w@1wt.eu>);
        Tue, 23 May 2017 10:34:04 -0400
Received: from mail.free-electrons.com ([62.4.15.54]:44068 "EHLO
        mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S934428AbdEWOeA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 23 May 2017 10:34:00 -0400
Date: Tue, 23 May 2017 16:33:55 +0200
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Liviu Dudau <Liviu.Dudau@arm.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Brian Starkey <brian.starkey@arm.com>,
        Sean Paul <seanpaul@chromium.org>,
        DRI devel <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Ville =?UTF-8?B?U3lyasOkbMOk?= <ville.syrjala@linux.intel.com>,
        Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH v5 0/2] drm: Introduce writeback connectors
Message-ID: <20170523163355.45756354@bbrezillon>
In-Reply-To: <20170515172057.30315-1-Liviu.Dudau@arm.com>
References: <20170515172057.30315-1-Liviu.Dudau@arm.com>
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Liviu,

On Mon, 15 May 2017 18:20:55 +0100
Liviu Dudau <Liviu.Dudau@arm.com> wrote:

> Hi,
> 
> This is v5 of the writeback connector series. Boris Brezillon thought
> that having to explicitly instantiate an encoder when using drm_writeback_connector
> is a bit too cumbersome, so I'm pushing out this version where we embed
> a virtual encoder inside drm_writeback_connector in order to satisfy the
> DRM framework. The caller of drm_writeback_connector_init() can control
> the embedded encoder by passing the drm_encoder_helper_funcs to be used.
> 
> Comments are welcome on the suitability of this series.

Whole series is:

Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Tested-by: Boris Brezillon <boris.brezillon@free-electrons.com>

Note that I tested it with the kms_writeback igt tests (available in
your branch [1]).

I'll post the VC4 changes soon.

Thanks,

Boris

> 
> Best regards,
> Liviu
> 
> Brian Starkey (2):
>   drm: Add writeback connector type
>   drm: writeback: Add out-fences for writeback connectors
> 
>  Documentation/gpu/drm-kms.rst       |   9 +
>  drivers/gpu/drm/Makefile            |   2 +-
>  drivers/gpu/drm/drm_atomic.c        | 229 ++++++++++++++++++++++-
>  drivers/gpu/drm/drm_atomic_helper.c |   6 +
>  drivers/gpu/drm/drm_connector.c     |   4 +-
>  drivers/gpu/drm/drm_writeback.c     | 362 ++++++++++++++++++++++++++++++++++++
>  include/drm/drm_atomic.h            |  11 ++
>  include/drm/drm_connector.h         |  13 ++
>  include/drm/drm_mode_config.h       |  22 +++
>  include/drm/drm_writeback.h         | 127 +++++++++++++
>  include/uapi/drm/drm_mode.h         |   1 +
>  11 files changed, 775 insertions(+), 11 deletions(-)
>  create mode 100644 drivers/gpu/drm/drm_writeback.c
>  create mode 100644 include/drm/drm_writeback.h
>