From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764733AbdEWQz6 (ORCPT ); Tue, 23 May 2017 12:55:58 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:41851 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759244AbdEWQz5 (ORCPT ); Tue, 23 May 2017 12:55:57 -0400 Date: Tue, 23 May 2017 18:55:54 +0200 From: Andrew Lunn To: Bogdan Purcareata Cc: "f.fainelli@gmail.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/2] net: phy: Update get_phy_c45_ids for Cortina PHYs Message-ID: <20170523165554.GB24029@lunn.ch> References: <1495554799-23060-1-git-send-email-bogdan.purcareata@nxp.com> <1495554799-23060-2-git-send-email-bogdan.purcareata@nxp.com> <20170523160353.GB21169@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The patches mentioned in the commit message add _some_ support for > the Cortina PHYs - mainly checking for devices at additional > locations. Once they are found, the phy IDs must be read from custom > locations. As a general principle, we don't add hacks in generic code to handle broken devices. We add generic mechanisms to work around the brokenness. In this case, by using ethernet-phy-id in the device tree, we are saying, this PHYs probing is totally borked, but we know it is there, at this address. Just load the driver. Please try to make ethernet-phy-id work. Andrew