From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030908AbdEWPQg (ORCPT ); Tue, 23 May 2017 11:16:36 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:45097 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933289AbdEWPQf (ORCPT ); Tue, 23 May 2017 11:16:35 -0400 Date: Tue, 23 May 2017 17:16:31 +0200 From: Boris Brezillon To: Liviu Dudau Cc: Daniel Vetter , Jani Nikula , Brian Starkey , Sean Paul , DRI devel , LKML , Ville =?UTF-8?B?U3lyasOkbMOk?= , Eric Anholt Subject: Re: [PATCH v5 0/2] drm: Introduce writeback connectors Message-ID: <20170523171631.1e34c5b1@bbrezillon> In-Reply-To: <20170523143842.GA7799@e110455-lin.cambridge.arm.com> References: <20170515172057.30315-1-Liviu.Dudau@arm.com> <20170523163355.45756354@bbrezillon> <20170523143842.GA7799@e110455-lin.cambridge.arm.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 May 2017 15:38:42 +0100 Liviu Dudau wrote: > On Tue, May 23, 2017 at 04:33:55PM +0200, Boris Brezillon wrote: > > Hi Liviu, > > Hi Boris, > > > > > On Mon, 15 May 2017 18:20:55 +0100 > > Liviu Dudau wrote: > > > > > Hi, > > > > > > This is v5 of the writeback connector series. Boris Brezillon thought > > > that having to explicitly instantiate an encoder when using drm_writeback_connector > > > is a bit too cumbersome, so I'm pushing out this version where we embed > > > a virtual encoder inside drm_writeback_connector in order to satisfy the > > > DRM framework. The caller of drm_writeback_connector_init() can control > > > the embedded encoder by passing the drm_encoder_helper_funcs to be used. > > > > > > Comments are welcome on the suitability of this series. > > > > Whole series is: > > > > Reviewed-by: Boris Brezillon > > Tested-by: Boris Brezillon > > > > Note that I tested it with the kms_writeback igt tests (available in > > your branch [1]). > > Thanks a lot! Now that you seem to be happy with the series (right?) I'll > try to push the kms_writeback tests into igt and get this series accepted. Well, I'm still not convinced that representing the writeback engine as a connector is the right thing to do (I mean, look at the encoder/connector hooks we are implementing, those are either empty stubs or stubs emulating the behavior of a connector to let the user think he's actually dealing with a real connector). But since I'm the only one to be concerned by this aspect, I guess I have to accept it :-). There's another thing I'm not completely happy with: the fact that we have to expose a function of the writeback engine driver and call it from the mode_config->commit_tail() hook, just because the core does not call encoder/connector hooks when the modes or display pipeline routes did not changed. I'd really prefer to have a hook that is unconditionally called to let the writeback engine driver decide when an update is actually needed. I guess this point can be addressed by extending the connector_helper vtable. Anyway, you have my R-b/T-b, so you're not blocked because of me ;-).