From: Tejun Heo <tj@kernel.org>
To: Shaohua Li <shli@fb.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
viro@zeniv.linux.org.uk, Kernel-team@fb.com
Subject: Re: [PATCH 1/5] kernfs: implement i_generation
Date: Tue, 23 May 2017 15:20:00 -0400 [thread overview]
Message-ID: <20170523192000.GE13222@htj.duckdns.org> (raw)
In-Reply-To: <20170523150946.GA6123@smirco-mbp.DHCP.thefacebook.com>
Hello,
On Tue, May 23, 2017 at 08:09:48AM -0700, Shaohua Li wrote:
> > i_generation is only supposed to be valid on a per-inode basis, so this
> > global counter seems really odd.
>
> What's the difference between per-inode or per-super? The i_generation doesn't
> need to be consecutive for an inode. I checked other fs, a lot of filesystems
> implement i_generation in this way, for example, f2fs, ext4.
One worry is that it is reasonably possible to wrap on the generation
number. Some setups go through cgroups really fast and wrapping 2^32
on the number of files ever created isn't that difficult over time.
This actually showing up as a malfunction would be very low probabilty
but is still nasty.
It'd be nice to give out unique 64bit id for each kn but then we can't
use idr. rbtree or extensible hash should work, right?
Thanks.
--
tejun
next prev parent reply other threads:[~2017-05-23 19:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 22:53 [PATCH 0/5] kernfs: add exportfs operations Shaohua Li
2017-05-22 22:53 ` [PATCH 1/5] kernfs: implement i_generation Shaohua Li
2017-05-23 7:41 ` Christoph Hellwig
2017-05-23 15:09 ` Shaohua Li
2017-05-23 19:20 ` Tejun Heo [this message]
2017-05-24 17:40 ` Christoph Hellwig
2017-05-22 22:53 ` [PATCH 2/5] kernfs: use idr instead of ida to manage inode number Shaohua Li
2017-05-22 22:53 ` [PATCH 3/5] kernfs: add an API to get kernfs node from " Shaohua Li
2017-05-22 22:53 ` [PATCH 4/5] kernfs: don't set dentry->d_fsdata Shaohua Li
2017-05-23 18:37 ` Tejun Heo
2017-05-22 22:53 ` [PATCH 5/5] kernfs: add exportfs operations Shaohua Li
2017-05-23 7:40 ` Christoph Hellwig
2017-05-23 18:57 ` Tejun Heo
2017-05-24 17:38 ` Christoph Hellwig
2017-05-24 17:39 ` Tejun Heo
2017-05-24 17:41 ` Christoph Hellwig
2017-05-24 17:46 ` Tejun Heo
2017-05-24 18:01 ` Shaohua Li
2017-05-23 18:59 ` Tejun Heo
2017-05-23 7:39 ` [PATCH 0/5] " Christoph Hellwig
2017-05-23 15:13 ` Shaohua Li
2017-05-23 19:06 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170523192000.GE13222@htj.duckdns.org \
--to=tj@kernel.org \
--cc=Kernel-team@fb.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@fb.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox