From: Matthias Kaehlcke <mka@chromium.org>
To: Zha Qipeng <qipeng.zha@intel.com>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>
Cc: linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>
Subject: [PATCH] platform/x86: intel_pmc_ipc: Delete unused function ipc_data_readb()
Date: Tue, 23 May 2017 13:55:39 -0700 [thread overview]
Message-ID: <20170523205539.71450-1-mka@chromium.org> (raw)
The function was added by commit 0a8b83530b6f ("intel_pmc_ipc: Add Intel
Apollo Lake PMC IPC driver") in 2015 and hasn't been used since then.
Removing it fixes the following warning when building with clang:
drivers/platform/x86/intel_pmc_ipc.c:189:18: error: unused function
'ipc_data_readb' [-Werror,-Wunused-function]
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
drivers/platform/x86/intel_pmc_ipc.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/platform/x86/intel_pmc_ipc.c b/drivers/platform/x86/intel_pmc_ipc.c
index e4d4dfe3e1d1..aa2fd58b75c4 100644
--- a/drivers/platform/x86/intel_pmc_ipc.c
+++ b/drivers/platform/x86/intel_pmc_ipc.c
@@ -186,11 +186,6 @@ static inline void ipc_data_writel(u32 data, u32 offset)
writel(data, ipcdev.ipc_base + IPC_WRITE_BUFFER + offset);
}
-static inline u8 ipc_data_readb(u32 offset)
-{
- return readb(ipcdev.ipc_base + IPC_READ_BUFFER + offset);
-}
-
static inline u32 ipc_data_readl(u32 offset)
{
return readl(ipcdev.ipc_base + IPC_READ_BUFFER + offset);
--
2.13.0.219.gdb65acc882-goog
next reply other threads:[~2017-05-23 20:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 20:55 Matthias Kaehlcke [this message]
2017-05-24 13:39 ` [PATCH] platform/x86: intel_pmc_ipc: Delete unused function ipc_data_readb() Alan Cox
2017-05-24 15:39 ` Doug Anderson
2017-05-25 13:26 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170523205539.71450-1-mka@chromium.org \
--to=mka@chromium.org \
--cc=andy@infradead.org \
--cc=dianders@chromium.org \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qipeng.zha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox