From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761109AbdEXC1R (ORCPT ); Tue, 23 May 2017 22:27:17 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:34574 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758128AbdEXC1P (ORCPT ); Tue, 23 May 2017 22:27:15 -0400 Date: Tue, 23 May 2017 19:27:10 -0700 From: Eduardo Valentin To: Viresh Kumar Cc: Amit Daniel Kachhap , Javi Merino , Zhang Rui , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] thermal: cpu_cooling: Replace kmalloc with kmalloc_array Message-ID: <20170524022706.GA11529@localhost.localdomain> References: <1495521460.2303.4.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v4O2RQ04001068 Hello, On Tue, May 23, 2017 at 12:33:06PM +0530, Viresh Kumar wrote: > Checkpatch reports following: > > WARNING: Prefer kmalloc_array over kmalloc with multiply > + cpufreq_cdev->freq_table = kmalloc(sizeof(*cpufreq_cdev->freq_table) * i, > > Fix that. That is how the patch would apply. Enter to continue WARNING: line over 80 characters #159: FILE: drivers/thermal/cpu_cooling.c:783: + cpufreq_cdev->freq_table = kmalloc(sizeof(*cpufreq_cdev->freq_table) * i, WARNING: Prefer kmalloc_array over kmalloc with multiply #159: FILE: drivers/thermal/cpu_cooling.c:783: + cpufreq_cdev->freq_table = kmalloc(sizeof(*cpufreq_cdev->freq_table) * i, + GFP_KERNEL); WARNING: line over 80 characters #190: FILE: include/linux/cpufreq.h:859: +static inline int cpufreq_table_count_valid_entries(const struct cpufreq_policy *policy) > > Signed-off-by: Viresh Kumar > --- > drivers/thermal/cpu_cooling.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c > index 1305020790b2..908a8014cf76 100644 > --- a/drivers/thermal/cpu_cooling.c > +++ b/drivers/thermal/cpu_cooling.c > @@ -724,8 +724,9 @@ __cpufreq_cooling_register(struct device_node *np, > /* max_level is an index, not a counter */ > cpufreq_cdev->max_level = i - 1; > > - cpufreq_cdev->freq_table = kmalloc(sizeof(*cpufreq_cdev->freq_table) * i, > - GFP_KERNEL); > + cpufreq_cdev->freq_table = kmalloc_array(i, > + sizeof(*cpufreq_cdev->freq_table), > + GFP_KERNEL); > if (!cpufreq_cdev->freq_table) { > cdev = ERR_PTR(-ENOMEM); > goto free_idle_time; > -- > 2.13.0.70.g6367777092d9 >