From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933207AbdEXKab (ORCPT ); Wed, 24 May 2017 06:30:31 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:42623 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763059AbdEXKa2 (ORCPT ); Wed, 24 May 2017 06:30:28 -0400 X-ME-Sender: X-Sasl-enc: yGqvvpjejTsY1dshmLnDVVQZHay6o+wJkkn2RAF73VDQ 1495621826 Date: Wed, 24 May 2017 20:30:24 +1000 From: "Tobin C. Harding" To: Richa Jha Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, teddy.wang@siliconmotion.com, linux-kernel@vger.kernel.org, sudipm.mukherjee@gmail.com, me@tobin.cc Subject: Re: staging: sm750fb: removed hungarian prfx and replace CamelCase variables Message-ID: <20170524103024.GB2319@eros> References: <1495612454-10505-1-git-send-email-richaj@cdac.in> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1495612454-10505-1-git-send-email-richaj@cdac.in> X-Mailer: Mutt 1.5.24 (2015-08-30) User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2017 at 01:24:14PM +0530, Richa Jha wrote: [snip] Nice work so far. I'm having trouble with your patches. Here are a few nitpicks to help you on your way. There are 4 emails in the last few days with similar subjects but they are not linked together. Also your email subject does not start with '[PATCH]', I doubt they will be picked up without it. You should read Documentation/process/submitting-patches.rst. There are some other issues with your subject line and commit-log, if you would like further comments please ask. So for initial patch the subject is something like [PATCH] staging: foo: Fix identifiers, hungarian notation and camel case If you submit version 2, it will then be [PATCH v2] staging: foo: Fix identifiers, hungarian notation and camel case Good luck, Tobin.