From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S940012AbdEXL6P (ORCPT ); Wed, 24 May 2017 07:58:15 -0400 Received: from mga03.intel.com ([134.134.136.65]:26553 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S939997AbdEXL6L (ORCPT ); Wed, 24 May 2017 07:58:11 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,386,1491289200"; d="scan'208";a="972503969" Date: Wed, 24 May 2017 14:53:43 +0300 From: Mika Westerberg To: Andy Shevchenko Cc: Linus Walleij , linux-gpio@vger.kernel.org, Dmitry Torokhov , Hans de Goede , linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, Jarkko Nikula , Jagadish Krishnamoorthy Subject: Re: [PATCH v2 09/12] gpio: acpi: Split out acpi_gpio_get_irq_resource() helper Message-ID: <20170524115343.GC8541@lahna.fi.intel.com> References: <20170523170327.18055-1-andriy.shevchenko@linux.intel.com> <20170523170327.18055-10-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170523170327.18055-10-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 23, 2017 at 08:03:24PM +0300, Andy Shevchenko wrote: > The helper does retrieve pointer to struct acpi_resource_gpio from > struct acpi_resource if it represents GpioInt() resource. > > It will be used by PNP code later on. > > Signed-off-by: Andy Shevchenko > --- > drivers/gpio/gpiolib-acpi.c | 23 ++++++++++++++++++----- > include/linux/acpi.h | 7 +++++++ > 2 files changed, 25 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c > index e431222edc2b..6bea176b066c 100644 > --- a/drivers/gpio/gpiolib-acpi.c > +++ b/drivers/gpio/gpiolib-acpi.c > @@ -165,6 +165,23 @@ static void acpi_gpio_chip_dh(acpi_handle handle, void *data) > /* The address of this function is used as a key. */ > } Since this is exported, it might be good idea to provide kernel-doc here. Anyway, Reviewed-by: Mika Westerberg > +bool acpi_gpio_get_irq_resource(struct acpi_resource *ares, > + struct acpi_resource_gpio **agpio) > +{ > + struct acpi_resource_gpio *gpio; > + > + if (ares->type != ACPI_RESOURCE_TYPE_GPIO) > + return false; > + > + gpio = &ares->data.gpio; > + if (gpio->connection_type != ACPI_RESOURCE_GPIO_TYPE_INT) > + return false; > + > + *agpio = gpio; > + return true; > +} > +EXPORT_SYMBOL_GPL(acpi_gpio_get_irq_resource);