From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032907AbdEXUYl (ORCPT ); Wed, 24 May 2017 16:24:41 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:60545 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032590AbdEXUYh (ORCPT ); Wed, 24 May 2017 16:24:37 -0400 Date: Wed, 24 May 2017 13:24:34 -0700 From: "Paul E. McKenney" To: kbuild test robot Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org Subject: Re: [rcu:rcu/next 91/92] include/linux/srcutiny.h:96:2: note: in expansion of macro 'pr_alert' Reply-To: paulmck@linux.vnet.ibm.com References: <201705250236.IMsDGpEz%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201705250236.IMsDGpEz%fengguang.wu@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17052420-0052-0000-0000-00000209AF08 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007112; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000212; SDB=6.00865108; UDB=6.00429527; IPR=6.00644888; BA=6.00005372; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015569; XFM=3.00000015; UTC=2017-05-24 20:24:35 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17052420-0053-0000-0000-000050B2C53E Message-Id: <20170524202434.GJ3956@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-24_13:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1705240096 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 25, 2017 at 02:56:41AM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/next > head: 71328ca7428fb7f5dfc146ee59ad9736df623cf3 > commit: 54ffb22bd8416ef9188dbe005b52ee5a1b5f6e5e [91/92] rcutorture: Move SRCU status printing to SRCU implementations > config: blackfin-allmodconfig (attached as .config) > compiler: bfin-uclinux-gcc (GCC) 6.2.0 > reproduce: > wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > git checkout 54ffb22bd8416ef9188dbe005b52ee5a1b5f6e5e > # save the attached .config to linux build tree > make.cross ARCH=blackfin > > All error/warnings (new ones prefixed by >>): > > include/linux/srcutiny.h: In function 'srcu_torture_stats_print': > >> arch/blackfin/kernel/module.c:7:40: error: 'mod' undeclared (first use in this function) > #define pr_fmt(fmt) "module %s: " fmt, mod->name > ^ > include/linux/printk.h:297:20: note: in expansion of macro 'pr_fmt' > printk(KERN_ALERT pr_fmt(fmt), ##__VA_ARGS__) > ^~~~~~ > >> include/linux/srcutiny.h:96:2: note: in expansion of macro 'pr_alert' > pr_alert("%s%s Tiny SRCU per-CPU(idx=%d): (%hd,%hd)\n", > ^~~~~~~~ > arch/blackfin/kernel/module.c:7:40: note: each undeclared identifier is reported only once for each function it appears in > #define pr_fmt(fmt) "module %s: " fmt, mod->name > ^ > include/linux/printk.h:297:20: note: in expansion of macro 'pr_fmt' > printk(KERN_ALERT pr_fmt(fmt), ##__VA_ARGS__) > ^~~~~~ > >> include/linux/srcutiny.h:96:2: note: in expansion of macro 'pr_alert' > pr_alert("%s%s Tiny SRCU per-CPU(idx=%d): (%hd,%hd)\n", > ^~~~~~~~ I confess, I don't see what is wrong with my pr_alert(). It instead looks to me like Blackfin has a problem with pr_fmt(). Or am I missing something here? Thanx, Paul > vim +/pr_alert +96 include/linux/srcutiny.h > > 80 { > 81 synchronize_srcu(sp); > 82 } > 83 > 84 static inline void srcu_barrier(struct srcu_struct *sp) > 85 { > 86 synchronize_srcu(sp); > 87 } > 88 > 89 /* Defined here to avoid size increase for non-torture kernels. */ > 90 static inline void srcu_torture_stats_print(struct srcu_struct *sp, > 91 char *tt, char *tf) > 92 { > 93 int idx; > 94 > 95 idx = READ_ONCE(sp->srcu_idx) & 0x1; > > 96 pr_alert("%s%s Tiny SRCU per-CPU(idx=%d): (%hd,%hd)\n", > 97 tt, tf, idx, > 98 READ_ONCE(sp->srcu_lock_nesting[!idx]), > 99 READ_ONCE(sp->srcu_lock_nesting[idx])); > 100 } > 101 > 102 #endif > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation