From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S940998AbdEXTai (ORCPT <rfc822;w@1wt.eu>);
        Wed, 24 May 2017 15:30:38 -0400
Received: from mail.kernel.org ([198.145.29.99]:39498 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S940867AbdEXTag (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 24 May 2017 15:30:36 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E812239E7
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org
Date: Wed, 24 May 2017 20:30:33 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Sanchayan Maity <maitysanchayan@gmail.com>,
        Gregor Boirie <gregor.boirie@parrot.com>,
        Matt Ranostay <mranostay@gmail.com>, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, Chris Healy <Chris.Healy@zii.aero>,
        Jeff White <Jeff.White@zii.aero>,
        Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Subject: Re: [PATCH] iio: hi8435: fix race between event enable and event
 generation
Message-ID: <20170524203033.558a09f9@kernel.org>
In-Reply-To: <20170523080729.20459-1-nikita.yoush@cogentembedded.com>
References: <20170523080729.20459-1-nikita.yoush@cogentembedded.com>
X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 23 May 2017 11:07:29 +0300
Nikita Yushchenko <nikita.yoush@cogentembedded.com> wrote:

> Add locking to avoid interference between reading/processing current
> sence in event enable and event generation paths.
> 
> Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Make sense.  Could you give a little more detail on the seriousness
of this bug?  I need to assess whether we just queue it up for the
next merge window or push it forward quicker as a bug fix and
whether to mark it for stable or not.

You probably have a better idea of how much it matters than I do!

Thanks,

Jonathan
> ---
>  drivers/iio/adc/hi8435.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/iio/adc/hi8435.c b/drivers/iio/adc/hi8435.c
> index ab59969b7c49..28fc699f00f6 100644
> --- a/drivers/iio/adc/hi8435.c
> +++ b/drivers/iio/adc/hi8435.c
> @@ -144,6 +144,8 @@ static int hi8435_write_event_config(struct iio_dev *idev,
>  	int ret;
>  	u32 tmp;
>  
> +	mutex_lock(&priv->lock);
> +
>  	if (state) {
>  		ret = hi8435_readl(priv, HI8435_SO31_0_REG, &tmp);
>  		if (ret < 0)
> @@ -157,6 +159,8 @@ static int hi8435_write_event_config(struct iio_dev *idev,
>  	} else
>  		priv->event_scan_mask &= ~BIT(chan->channel);
>  
> +	mutex_unlock(&priv->lock);
> +
>  	return 0;
>  }
>  
> @@ -449,12 +453,16 @@ static irqreturn_t hi8435_trigger_handler(int irq, void *private)
>  	u32 val;
>  	int ret;
>  
> +	mutex_lock(&priv->lock);
> +
>  	ret = hi8435_readl(priv, HI8435_SO31_0_REG, &val);
>  	if (ret < 0)
>  		goto err_read;
>  
>  	hi8435_iio_push_event(idev, val);
>  
> +	mutex_unlock(&priv->lock);
> +
>  err_read:
>  	iio_trigger_notify_done(idev->trig);
>