Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems

David Rientjes
2017-05-23T01:35:27Z

On Mon, 22 May 2017, Andrew Morton wrote:

> > > Is clang not inlining kmalloc_large_node_hook() for some reason? I don't
> > > think this should ever warn on gcc.
> >
> > clang warns about unused static inline functions outside of header
> > files, in difference to gcc.
>
> I wish it wouldn't. These patches just add clutter.
>

Matthias, what breaks if you do this?

diff --git a/include/linux/compiler-clang.h b/include/linux/compiler-clang.h
index de179993e039..e1895ce6fa1b 100644
--- a/include/linux/compiler-clang.h
+++ b/include/linux/compiler-clang.h
@@ -15,3 +15,8 @@
* with any version that can compile the kernel
*/
#define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
+
+#ifdef inline
+#undef inline
+#define inline __attribute__((unused))
+#endif