Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems

David Rientjes
2017-05-22T20:39:32Z

On Fri, 19 May 2017, Matthias Kaehlcke wrote:

> The function is only used when CONFIG_NUMA=y. Placing it in an #ifdef
> block fixes the following warning when building with clang:
>
> mm/slub.c:1246:20: error: unused function 'kmalloc_large_node_hook'
> [-Werror,-Wunused-function]
>

Is clang not inlining kmalloc_large_node_hook() for some reason? I don't
think this should ever warn on gcc.

> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>

Acked-by: David Rientjes <rientjes@google.com>

> ---
> mm/slub.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 57e5156f02be..66e1046435b7 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -1313,11 +1313,14 @@ static inline void dec_slabs_node(struct kmem_cache *s, int node,
> * Hooks for other subsystems that check memory allocations. In a typical
> * production configuration these hooks all should produce no code at all.
> */
> +
> +#ifdef CONFIG_NUMA
> static inline void kmalloc_large_node_hook(void *ptr, size_t size, gfp_t flags)
> {
> kmemleak_alloc(ptr, size, 1, flags);
> kasan_kmalloc_large(ptr, size, flags);
> }
> +#endif
>
> static inline void kfree_hook(const void *x)
> {