From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422991AbdEXX23 (ORCPT ); Wed, 24 May 2017 19:28:29 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:50427 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033882AbdEXX2W (ORCPT ); Wed, 24 May 2017 19:28:22 -0400 X-ME-Sender: X-Sasl-enc: VF9N1X37vDuFR0Xa/9adgmsIdpLyzR36H5JWx3c9Pu1y 1495668501 Date: Thu, 25 May 2017 09:28:18 +1000 From: "Tobin C. Harding" To: srishti sharma Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, f.fainelli@gmail.com, sbranden@broadcom.com, swarren@wwwdotorg.org, rjui@broadcom.com, lee@kernel.org, vicmos89@gmail.com, linux-kernel@vger.kernel.org, eric@anholt.net, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, mzoran@crowfest.net, dan.carpenter@oracle.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] Staging: bcm2835-audio: bcm2835-ctl.c: Fixed a comment coding style issue. Message-ID: <20170524232818.GF2319@eros> References: <1495636394-2431-1-git-send-email-srishtishar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1495636394-2431-1-git-send-email-srishtishar@gmail.com> X-Mailer: Mutt 1.5.24 (2015-08-30) User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2017 at 08:03:14PM +0530, srishti sharma wrote: This driver is not in Greg KH's staging tree. You may like to work off of that tree when doing staging patches. https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ To aid you future patches here are a couple of minor comments for you. > fixed a trailing */ issue You may like to be more explicit here using the format described in Documentation/process/submitting-patches.rst (Section 2 Describe your changes). This goes for your subject line as well. > Signed-off-by: srishti sharma > --- > drivers/staging/bcm2835-audio/bcm2835-ctl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/bcm2835-audio/bcm2835-ctl.c > index a4ffa1b..38fabab 100644 > --- a/drivers/staging/bcm2835-audio/bcm2835-ctl.c > +++ b/drivers/staging/bcm2835-audio/bcm2835-ctl.c > @@ -247,8 +247,8 @@ static int snd_bcm2835_spdif_mask_get(struct snd_kcontrol *kcontrol, > struct snd_ctl_elem_value *ucontrol) > { > /* bcm2835 supports only consumer mode and sets all other format flags > - * automatically. So the only thing left is signalling non-audio > - * content */ > + * automatically. So the only thing left is signalling non-audio content > + */ And for completeness this is the block comment style in networking code, the rest of the kernel uses the format /* * block comment blah blah * on multiple lines */ Good luck, Tobin.