From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968601AbdEYHeH (ORCPT ); Thu, 25 May 2017 03:34:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:51538 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968571AbdEYHeE (ORCPT ); Thu, 25 May 2017 03:34:04 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8CC0239EC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=shawnguo@kernel.org Date: Thu, 25 May 2017 15:33:08 +0800 From: Shawn Guo To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Wolfram Sang , Rob Herring , devicetree@vger.kernel.org, Stuart Yoder , Li Yang , Rob Herring , Hongtao Jia , linux-arm-kernel@lists.infradead.org, Will Deacon , Herbert Xu , Mark Rutland , Catalin Marinas , Horia =?utf-8?Q?Geant=C4=83?= Subject: Re: [PATCH v5 14/20] arm64: dts: ls1043a: Add generic compatible string for I2C EEPROM Message-ID: <20170525073304.GX26102@dragon> References: <20170523133448.4794-1-javier@dowhile0.org> <20170523133448.4794-15-javier@dowhile0.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170523133448.4794-15-javier@dowhile0.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 23, 2017 at 03:34:42PM +0200, Javier Martinez Canillas wrote: > The at24 driver allows to register I2C EEPROM chips using different vendor > and devices, but the I2C subsystem does not take the vendor into account > when matching using the I2C table since it only has device entries. > > But when matching using an OF table, both the vendor and device has to be > taken into account so the driver defines only a set of compatible strings > using the "atmel" vendor as a generic fallback for compatible I2C devices. > > So add this generic fallback to the device node compatible string to make > the device to match the driver using the OF device ID table. > > Signed-off-by: Javier Martinez Canillas Applied, thanks.