From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1423640AbdEYIKT (ORCPT <rfc822;w@1wt.eu>);
        Thu, 25 May 2017 04:10:19 -0400
Received: from mx1.redhat.com ([209.132.183.28]:28606 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1423625AbdEYIKO (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 25 May 2017 04:10:14 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 98AFD7249D
Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jolsa@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 98AFD7249D
Date: Thu, 25 May 2017 10:10:04 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: David Carrillo-Cisneros <davidcc@google.com>
Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>, Simon Que <sque@chromium.org>,
        Wang Nan <wangnan0@huawei.com>, Jiri Olsa <jolsa@kernel.org>,
        He Kuang <hekuang@huawei.com>, Masami Hiramatsu <mhiramat@kernel.org>,
        David Ahern <dsa@cumulusnetworks.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Stephane Eranian <eranian@google.com>, Paul Turner <pjt@google.com>
Subject: Re: [PATCH v2 13/13] perf tools: add feature header record to
 pipe-mode
Message-ID: <20170525081004.GO14467@krava>
References: <20170523074853.54892-1-davidcc@google.com>
 <20170523074853.54892-14-davidcc@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170523074853.54892-14-davidcc@google.com>
User-Agent: Mutt/1.8.0 (2017-02-23)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 25 May 2017 08:10:08 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 23, 2017 at 12:48:53AM -0700, David Carrillo-Cisneros wrote:

SNIP

> +int perf_event__synthesize_features(struct perf_tool *tool,
> +				    struct perf_session *session,
> +				    struct perf_evlist *evlist,
> +				    perf_event__handler_t process)
> +{
> +	struct perf_header *header = &session->header;
> +	struct feat_fd fdd;
> +	struct feature_event *fe;
> +	size_t sz, sz_hdr;
> +	int feat, ret;
> +
> +	sz_hdr = sizeof(fe->header);
> +	sz = sizeof(union perf_event);
> +	/* get a nice alignment */
> +	sz = PERF_ALIGN(sz, getpagesize());
> +
> +	memset(&fdd, 0, sizeof(fdd));
> +
> +	fdd.buf = malloc(sz);
> +	if (!fdd.buf)
> +		return -ENOMEM;
> +
> +	fdd.size = sz - sz_hdr;
> +
> +	for_each_set_bit(feat, header->adds_features, HEADER_FEAT_BITS) {
> +		if (!feat_ops[feat].has_record) {
> +			pr_debug("No record header feature for header :%d\n", feat);
> +			continue;
> +		}
> +
> +		fdd.offset = sizeof(*fe);
> +
> +		ret = feat_ops[feat].write(&fdd, evlist);
> +		if (ret || fdd.offset <= (ssize_t)sizeof(*fe)) {
> +			pr_debug("Error writing feature\n");
> +			continue;
> +		}
> +
> +		/* fdd.buf may have changed due to realloc in do_write() */

right, so how's ensured the data never cross the maximum event size (0xffff) ?

I think do_write should have some check on that

jirka