From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756331AbdEYIXc (ORCPT <rfc822;w@1wt.eu>);
        Thu, 25 May 2017 04:23:32 -0400
Received: from mail.kernel.org ([198.145.29.99]:54546 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1423697AbdEYIVh (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 25 May 2017 04:21:37 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62B85239EB
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=shawnguo@kernel.org
Date: Thu, 25 May 2017 16:20:32 +0800
From: Shawn Guo <shawnguo@kernel.org>
To: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: Sascha Hauer <kernel@pengutronix.de>, Stefan Agner <stefan@agner.ch>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Russell King <linux@armlinux.org.uk>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
        Chris Healy <Chris.Healy@zii.aero>, Jeff White <Jeff.White@zii.aero>
Subject: Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: add hi8435 device
Message-ID: <20170525082030.GB26102@dragon>
References: <20170522131010.3537-1-nikita.yoush@cogentembedded.com>
 <20170525070007.GU26102@dragon>
 <eb86f383-3c27-2276-6213-99c5143420f5@cogentembedded.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <eb86f383-3c27-2276-6213-99c5143420f5@cogentembedded.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 25, 2017 at 11:06:47AM +0300, Nikita Yushchenko wrote:
> >> +&edma1 {
> >> +	status = "okay";
> >> +};
> >> +
> >> +&dspi2 {
> > 
> > Please keep these labelled nodes sort alphabetically.
> 
> Ok
> 
> >> +	bus-num = <1>;
> >> +	pinctrl-names = "default";
> >> +	pinctrl-0 = <&pinctrl_dspi2>;
> >> +	status = "okay";
> > 
> > We usually have 'status' line at the bottom of property list.
> 
> Ok
> 
> >> +	spi-num-chipselects = <2>;
> >> +
> >> +	hi8435@1 {
> > 
> > Node name should be something generic, while label can be specific
> > model name.  The following form might be better.
> > 
> > 	hi8435: sensor@1
> 
> Ok
> 
> Although the same file, in lines nearby, has m25p128@0 and at93c46d@1.

It seems that I need more eyes to help review.

Shawn