From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762786AbdEYL3H (ORCPT ); Thu, 25 May 2017 07:29:07 -0400 Received: from mx2.suse.de ([195.135.220.15]:47306 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751503AbdEYL3E (ORCPT ); Thu, 25 May 2017 07:29:04 -0400 Date: Thu, 25 May 2017 13:29:02 +0200 From: Petr Mladek To: Sergey Senozhatsky Cc: Nicolas Iooss , Steven Rostedt , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] printk: add __printf attributes to internal functions Message-ID: <20170525112902.GG12489@pathway.suse.cz> References: <20170522152211.GF12489@pathway.suse.cz> <20170524054950.6722-1-nicolas.iooss_linux@m4x.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170524054950.6722-1-nicolas.iooss_linux@m4x.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 2017-05-24 07:49:50, Nicolas Iooss wrote: > When compiling with -Wsuggest-attribute=format, gcc complains that some > functions in kernel/printk/printk_safe.c transmit their argument to > printf-like functions without having a printf attribute. Silence these > warnings by adding relevant __printf attributes. > > Signed-off-by: Nicolas Iooss > Acked-by: Petr Mladek > --- > v2: add __printf attribute to the definition of vprintk_nmi() which is > used when CONFIG_PRINTK_NMI is not defined. Sergey, I believe that that your Reviewed-by is still valid even after this small update. Is that true, please? Best Regards, Petr