From: Petr Mladek <pmladek@suse.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>, Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Eric Biederman <ebiederm@xmission.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, Pavel Machek <pavel@ucw.cz>,
Andreas Mohr <andi@lisas.de>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCHv3 1/5] printk: move printk_pending out of per-cpu
Date: Thu, 25 May 2017 14:43:53 +0200 [thread overview]
Message-ID: <20170525124352.GH26699@pathway.suse.cz> (raw)
In-Reply-To: <20170525123633.GE386@jagdpanzerIV.localdomain>
On Thu 2017-05-25 21:36:33, Sergey Senozhatsky wrote:
> On (05/25/17 14:11), Petr Mladek wrote:
> [..]
> > The variable is used only when CONFIG_PRINTK is defined at
> > the moment, so this produces a warning about an unused variable.
> >
>
> interesting... `printk_pending' is used in console_unlock(), which is
> always available.
Yeah, I see. But this usage is introduced in the 2nd patch. I started
the review sequentially ;-)
Best Regards,
Petr
next prev parent reply other threads:[~2017-05-25 12:44 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 8:28 [RFC][PATCHv3 0/5] printk: introduce printing kernel thread Sergey Senozhatsky
2017-05-09 8:28 ` [RFC][PATCHv3 1/5] printk: move printk_pending out of per-cpu Sergey Senozhatsky
2017-05-25 12:11 ` Petr Mladek
2017-05-25 12:36 ` Sergey Senozhatsky
2017-05-25 12:43 ` Petr Mladek [this message]
2017-05-09 8:28 ` [RFC][PATCHv3 2/5] printk: introduce printing kernel thread Sergey Senozhatsky
2017-05-10 5:59 ` Sergey Senozhatsky
2017-05-29 9:29 ` Petr Mladek
2017-05-29 12:12 ` Jan Kara
2017-05-31 7:30 ` Sergey Senozhatsky
2017-05-31 21:44 ` Andreas Mohr
2017-06-01 7:21 ` Sergey Senozhatsky
2017-06-01 7:23 ` Sergey Senozhatsky
2017-06-01 9:20 ` Sergey Senozhatsky
2017-06-28 13:17 ` Petr Mladek
2017-06-29 7:40 ` Sergey Senozhatsky
2017-06-28 12:45 ` Petr Mladek
2017-05-31 7:22 ` Sergey Senozhatsky
2017-06-28 12:19 ` Petr Mladek
2017-06-29 6:26 ` Andreas Mohr
2017-06-29 7:00 ` Andreas Mohr
2017-06-29 7:33 ` Sergey Senozhatsky
2017-06-29 11:24 ` Tetsuo Handa
2017-06-30 7:01 ` Sergey Senozhatsky
2017-06-30 10:18 ` Tetsuo Handa
2017-06-30 11:57 ` Sergey Senozhatsky
2017-06-30 12:35 ` Tetsuo Handa
2017-06-30 12:50 ` Sergey Senozhatsky
2017-06-30 13:16 ` Petr Mladek
2017-06-30 13:38 ` Sergey Senozhatsky
2017-07-03 11:11 ` Sergey Senozhatsky
2017-07-02 20:27 ` Pavel Machek
2017-07-05 16:36 ` Sergey Senozhatsky
2017-07-03 19:34 ` Steven Rostedt
2017-07-04 5:26 ` Sergey Senozhatsky
2017-07-04 6:53 ` Sergey Senozhatsky
2017-06-30 14:10 ` Sergey Senozhatsky
2017-06-30 11:54 ` Petr Mladek
2017-06-30 12:42 ` Sergey Senozhatsky
2017-06-30 13:33 ` Steven Rostedt
2017-06-30 14:28 ` Sergey Senozhatsky
2017-06-30 14:45 ` Steven Rostedt
2017-07-01 1:50 ` Sergey Senozhatsky
2017-07-04 14:03 ` Petr Mladek
2017-07-05 5:02 ` Sergey Senozhatsky
2017-05-09 8:28 ` [RFC][PATCHv3 3/5] printk: add enforce_emergency parameter Sergey Senozhatsky
2017-05-09 8:28 ` [RFC][PATCHv3 4/5] printk: enable printk offloading Sergey Senozhatsky
2017-05-09 8:28 ` [RFC][PATCHv3 5/5] printk: register PM notifier Sergey Senozhatsky
2017-05-30 9:55 ` Petr Mladek
2017-05-31 6:42 ` Sergey Senozhatsky
2017-06-27 14:45 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170525124352.GH26699@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=andi@lisas.de \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox