From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S937991AbdEYMoB (ORCPT <rfc822;w@1wt.eu>);
        Thu, 25 May 2017 08:44:01 -0400
Received: from mx2.suse.de ([195.135.220.15]:55494 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S937897AbdEYMn5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 25 May 2017 08:43:57 -0400
Date: Thu, 25 May 2017 14:43:53 +0200
From: Petr Mladek <pmladek@suse.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>, Jan Kara <jack@suse.cz>,
        Andrew Morton <akpm@linux-foundation.org>,
        Peter Zijlstra <peterz@infradead.org>,
        "Rafael J . Wysocki" <rjw@rjwysocki.net>,
        Eric Biederman <ebiederm@xmission.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.com>, Pavel Machek <pavel@ucw.cz>,
        Andreas Mohr <andi@lisas.de>,
        Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCHv3 1/5] printk: move printk_pending out of per-cpu
Message-ID: <20170525124352.GH26699@pathway.suse.cz>
References: <20170509082859.854-1-sergey.senozhatsky@gmail.com>
 <20170509082859.854-2-sergey.senozhatsky@gmail.com>
 <20170525121107.GG26699@pathway.suse.cz>
 <20170525123633.GE386@jagdpanzerIV.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170525123633.GE386@jagdpanzerIV.localdomain>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu 2017-05-25 21:36:33, Sergey Senozhatsky wrote:
> On (05/25/17 14:11), Petr Mladek wrote:
> [..]
> > The variable is used only when CONFIG_PRINTK is defined at
> > the moment, so this produces a warning about an unused variable.
> > 
> 
> interesting... `printk_pending' is used in console_unlock(), which is
> always available.

Yeah, I see. But this usage is introduced in the 2nd patch. I started
the review sequentially ;-)

Best Regards,
Petr